2020-09-21 19:38:25

by Paul E. McKenney

[permalink] [raw]
Subject: [GIT RFC PULL rcu/urgent] Fix rcu-tasks compilation warning

Hello!

This pull request contains a single commit that fixes a bug that
was introduced in the last merge window. This bug causes a compiler
warning complaining about show_rcu_tasks_classic_gp_kthread() being an
unused static function in !SMP kernels. The fix is straightforward,
just adding an "inline" to make this a static inline function, thus
avoiding the warning. This bug was reported by Laurent Pinchart (CCed),
who would like it fixed sooner rather than later. So:

The following changes since commit 9123e3a74ec7b934a4a099e98af6a61c2f80bbf5:

Linux 5.9-rc1 (2020-08-16 13:04:57 -0700)

are available in the git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git rcu/urgent

for you to fetch changes up to 78edc005f477a4987ee0a5d96bfe117295c231fd:

rcu-tasks: Prevent complaints of unused show_rcu_tasks_classic_gp_kthread() (2020-09-16 16:32:36 -0700)

----------------------------------------------------------------
Paul E. McKenney (1):
rcu-tasks: Prevent complaints of unused show_rcu_tasks_classic_gp_kthread()

kernel/rcu/tasks.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


2020-09-21 19:48:24

by Linus Torvalds

[permalink] [raw]
Subject: Re: [GIT RFC PULL rcu/urgent] Fix rcu-tasks compilation warning

On Mon, Sep 21, 2020 at 12:37 PM Paul E. McKenney <[email protected]> wrote:
>
> This bug was reported by Laurent Pinchart (CCed),
> who would like it fixed sooner rather than later.

I'm assuming that sentence and me being cc'd means that you'd prefer
to get this merged directly rather than go through the usual -tip
shenanigans.

I've pulled it.

Linus

2020-09-21 19:52:45

by pr-tracker-bot

[permalink] [raw]
Subject: Re: [GIT RFC PULL rcu/urgent] Fix rcu-tasks compilation warning

The pull request you sent on Mon, 21 Sep 2020 12:37:03 -0700:

> git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git rcu/urgent

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/98477740630f270aecf648f1d6a9dbc6027d4ff1

Thank you!

--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

2020-09-21 20:36:58

by Paul E. McKenney

[permalink] [raw]
Subject: Re: [GIT RFC PULL rcu/urgent] Fix rcu-tasks compilation warning

On Mon, Sep 21, 2020 at 12:46:22PM -0700, Linus Torvalds wrote:
> On Mon, Sep 21, 2020 at 12:37 PM Paul E. McKenney <[email protected]> wrote:
> >
> > This bug was reported by Laurent Pinchart (CCed),
> > who would like it fixed sooner rather than later.
>
> I'm assuming that sentence and me being cc'd means that you'd prefer
> to get this merged directly rather than go through the usual -tip
> shenanigans.

I was good either way, but I have reason to believe that Laurent deeply
appreciates the direct merge. ;-)

> I've pulled it.

Thank you!

Thanx, Paul

2020-09-21 20:59:28

by Laurent Pinchart

[permalink] [raw]
Subject: Re: [GIT RFC PULL rcu/urgent] Fix rcu-tasks compilation warning

On Mon, Sep 21, 2020 at 01:35:34PM -0700, Paul E. McKenney wrote:
> On Mon, Sep 21, 2020 at 12:46:22PM -0700, Linus Torvalds wrote:
> > On Mon, Sep 21, 2020 at 12:37 PM Paul E. McKenney <[email protected]> wrote:
> > >
> > > This bug was reported by Laurent Pinchart (CCed),
> > > who would like it fixed sooner rather than later.
> >
> > I'm assuming that sentence and me being cc'd means that you'd prefer
> > to get this merged directly rather than go through the usual -tip
> > shenanigans.
>
> I was good either way, but I have reason to believe that Laurent deeply
> appreciates the direct merge. ;-)

It fixed a compilation breakage introduced in v5.9 for one of my boards,
so yes :-) Thank you.

> > I've pulled it.
>
> Thank you!

--
Regards,

Laurent Pinchart