2020-09-22 10:55:29

by Zou Wei

Subject: [PATCH -next] firmware: ti_sci: Remove unneeded semicolon

Fixes coccicheck warning:

./drivers/firmware/ti_sci.c:1759:2-3: Unneeded semicolon
./drivers/firmware/ti_sci.c:2191:2-3: Unneeded semicolon

Fixes: 9c19fb6895be ("firmware: ti_sci: Add support for RM core ops")
Fixes: 68608b5e5063 ("firmware: ti_sci: Add resource management APIs for ringacc, psi-l and udma")
Signed-off-by: Zou Wei <[email protected]>
---
drivers/firmware/ti_sci.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/firmware/ti_sci.c b/drivers/firmware/ti_sci.c
index 896f53e..e0c8adf 100644
--- a/drivers/firmware/ti_sci.c
+++ b/drivers/firmware/ti_sci.c
@@ -1756,7 +1756,7 @@ static int ti_sci_get_resource_range(const struct ti_sci_handle *handle,
} else {
*range_start = resp->range_start;
*range_num = resp->range_num;
- };
+ }

fail:
ti_sci_put_one_xfer(&info->minfo, xfer);
@@ -2188,7 +2188,7 @@ static int ti_sci_cmd_ring_get_config(const struct ti_sci_handle *handle,
*size = resp->size;
if (order_id)
*order_id = resp->order_id;
- };
+ }

fail:
ti_sci_put_one_xfer(&info->minfo, xfer);
--
2.6.2

2020-09-22 11:49:16

by Nishanth Menon

Subject: Re: [PATCH -next] firmware: ti_sci: Remove unneeded semicolon

On 18:59-20200922, Zou Wei wrote:
> Fixes coccicheck warning:
>
> ./drivers/firmware/ti_sci.c:1759:2-3: Unneeded semicolon
> ./drivers/firmware/ti_sci.c:2191:2-3: Unneeded semicolon
>
> Fixes: 9c19fb6895be ("firmware: ti_sci: Add support for RM core ops")
> Fixes: 68608b5e5063 ("firmware: ti_sci: Add resource management APIs for ringacc, psi-l and udma")
> Signed-off-by: Zou Wei <[email protected]>
> ---
> drivers/firmware/ti_sci.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/firmware/ti_sci.c b/drivers/firmware/ti_sci.c
> index 896f53e..e0c8adf 100644
> --- a/drivers/firmware/ti_sci.c
> +++ b/drivers/firmware/ti_sci.c
> @@ -1756,7 +1756,7 @@ static int ti_sci_get_resource_range(const struct ti_sci_handle *handle,
> } else {
> *range_start = resp->range_start;
> *range_num = resp->range_num;
> - };
> + }
>
> fail:
> ti_sci_put_one_xfer(&info->minfo, xfer);
> @@ -2188,7 +2188,7 @@ static int ti_sci_cmd_ring_get_config(const struct ti_sci_handle *handle,
> *size = resp->size;
> if (order_id)
> *order_id = resp->order_id;
> - };
> + }
>
> fail:
> ti_sci_put_one_xfer(&info->minfo, xfer);

Thanks.
Reviewed-by: Nishanth Menon <[email protected]>

--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D