2020-09-23 10:14:06

by yekai (A)

Subject: [PATCH v3 1/2] uacce: delete some redundant code.

Delete some redundant code.

Signed-off-by: Kai Ye <[email protected]>
Reviewed-by: Zhou Wang <[email protected]>
Reviewed-by: Jonathan Cameron <[email protected]>
Acked-by: Zhangfei Gao <[email protected]>
---
drivers/misc/uacce/uacce.c | 11 -----------
1 file changed, 11 deletions(-)

diff --git a/drivers/misc/uacce/uacce.c b/drivers/misc/uacce/uacce.c
index 107028e..9b83bc5 100644
--- a/drivers/misc/uacce/uacce.c
+++ b/drivers/misc/uacce/uacce.c
@@ -239,17 +239,6 @@ static int uacce_fops_mmap(struct file *filep, struct vm_area_struct *vma)

switch (type) {
case UACCE_QFRT_MMIO:
- if (!uacce->ops->mmap) {
- ret = -EINVAL;
- goto out_with_lock;
- }
-
- ret = uacce->ops->mmap(q, vma, qfr);
- if (ret)
- goto out_with_lock;
-
- break;
-
case UACCE_QFRT_DUS:
if (!uacce->ops->mmap) {
ret = -EINVAL;
--
2.8.1

2020-11-02 07:39:34

by Zhou Wang

Subject: Re: [PATCH v3 1/2] uacce: delete some redundant code.

On 2020/9/23 18:09, Kai Ye wrote:
> Delete some redundant code.
>
> Signed-off-by: Kai Ye <[email protected]>
> Reviewed-by: Zhou Wang <[email protected]>
> Reviewed-by: Jonathan Cameron <[email protected]>
> Acked-by: Zhangfei Gao <[email protected]>
> ---
> drivers/misc/uacce/uacce.c | 11 -----------
> 1 file changed, 11 deletions(-)
>
> diff --git a/drivers/misc/uacce/uacce.c b/drivers/misc/uacce/uacce.c
> index 107028e..9b83bc5 100644
> --- a/drivers/misc/uacce/uacce.c
> +++ b/drivers/misc/uacce/uacce.c
> @@ -239,17 +239,6 @@ static int uacce_fops_mmap(struct file *filep, struct vm_area_struct *vma)
>
> switch (type) {
> case UACCE_QFRT_MMIO:
> - if (!uacce->ops->mmap) {
> - ret = -EINVAL;
> - goto out_with_lock;
> - }
> -
> - ret = uacce->ops->mmap(q, vma, qfr);
> - if (ret)
> - goto out_with_lock;
> -
> - break;
> -
> case UACCE_QFRT_DUS:
> if (!uacce->ops->mmap) {
> ret = -EINVAL;
>

Hi Hartman,

Could you take this patch?

Best,
Zhou