2020-09-29 00:52:26

by Tian Tao

[permalink] [raw]
Subject: [PATCH] drm/hisilicon: Delete the unused macro

The macro PADDING is no longer used. Delete it.

Signed-off-by: Tian Tao <[email protected]>
---
drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c
index 4d57ec6..b3a81da 100644
--- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c
+++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c
@@ -52,8 +52,6 @@ static const struct hibmc_dislay_pll_config hibmc_pll_table[] = {
{1920, 1200, CRT_PLL1_HS_193MHZ, CRT_PLL2_HS_193MHZ},
};

-#define PADDING(align, data) (((data) + (align) - 1) & (~((align) - 1)))
-
static int hibmc_plane_atomic_check(struct drm_plane *plane,
struct drm_plane_state *state)
{
--
2.7.4


2020-09-29 07:26:53

by Thomas Zimmermann

[permalink] [raw]
Subject: Re: [PATCH] drm/hisilicon: Delete the unused macro



Am 29.09.20 um 02:45 schrieb Tian Tao:
> The macro PADDING is no longer used. Delete it.
>
> Signed-off-by: Tian Tao <[email protected]>

Reviewed-by: Thomas Zimmermann <[email protected]>

> ---
> drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c
> index 4d57ec6..b3a81da 100644
> --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c
> +++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c
> @@ -52,8 +52,6 @@ static const struct hibmc_dislay_pll_config hibmc_pll_table[] = {
> {1920, 1200, CRT_PLL1_HS_193MHZ, CRT_PLL2_HS_193MHZ},
> };
>
> -#define PADDING(align, data) (((data) + (align) - 1) & (~((align) - 1)))
> -
> static int hibmc_plane_atomic_check(struct drm_plane *plane,
> struct drm_plane_state *state)
> {
>

--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer

Attachments:
signature.asc (527.00 B)
OpenPGP digital signature

2020-09-29 07:31:38

by tiantao (H)

[permalink] [raw]
Subject: Re: [PATCH] drm/hisilicon: Delete the unused macro



在 2020/9/29 15:24, Thomas Zimmermann 写道:
>
>
> Am 29.09.20 um 02:45 schrieb Tian Tao:
>> The macro PADDING is no longer used. Delete it.
>>
>> Signed-off-by: Tian Tao <[email protected]>
>
> Reviewed-by: Thomas Zimmermann <[email protected]>
>
Thanks a lot for the timely help with the review code!
>> ---
>> drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c
>> index 4d57ec6..b3a81da 100644
>> --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c
>> +++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c
>> @@ -52,8 +52,6 @@ static const struct hibmc_dislay_pll_config hibmc_pll_table[] = {
>> {1920, 1200, CRT_PLL1_HS_193MHZ, CRT_PLL2_HS_193MHZ},
>> };
>>
>> -#define PADDING(align, data) (((data) + (align) - 1) & (~((align) - 1)))
>> -
>> static int hibmc_plane_atomic_check(struct drm_plane *plane,
>> struct drm_plane_state *state)
>> {
>>
>