Subject says it all. This rename was briefly discussed in this other patch: https://www.spinics.net/lists/linux-leds/msg16865.html (I don't know another way to link to emails, so I'll just use this archive).
Feel free to suggest another name for the commit; that was just the better name I could come up with :/ .
On Mon, 5 Oct 2020 22:17:14 +0200 (CEST)
[email protected] wrote:
> Subject says it all. This rename was briefly discussed in this other patch: https://www.spinics.net/lists/linux-leds/msg16865.html (I don't know another way to link to emails, so I'll just use this archive).
>
> Feel free to suggest another name for the commit; that was just the better name I could come up with :/ .
>
>
>
>
Gabriel,
the subject of the patch should be
leds: lm3697: Rename struct into more appropiate name
("leds: " is prefixed). Look at history
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/log/drivers/leds?h=v5.9-rc8
The commit message should mention why you are renaming the type
(something like "to be semantically more correct, since that structure
represents LED control bank as described by the datasheet").
Also it seems that you are using git format-patch for generating patch
files, but you are sending these patches as regular e-mail attachements.
You should instead use git send-email, as is normally required
for kernel patches (and they would also appear in patchwork
(https://patches.linaro.org/project/linux-leds/list/). Please look at
https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html
and https://git-send-email.io/.
Marek
The reason I didn't use git send-mail earlier is because Tutanota doesn't supports SMTP and Protonmail requires a paid account for using SMTP/IMAP. However, I made an account creation request for Disroot(which does support SMTP for free), so when/if the account gets created I'll send future patches through there.
Oct 6, 2020, 23:26 by [email protected]:
> On Mon, 5 Oct 2020 22:17:14 +0200 (CEST)
> [email protected] wrote:
>
>> Subject says it all. This rename was briefly discussed in this other patch: https://www.spinics.net/lists/linux-leds/msg16865.html (I don't know another way to link to emails, so I'll just use this archive).
>>
>> Feel free to suggest another name for the commit; that was just the better name I could come up with :/ .
>>
>>
>>
>
> Gabriel,
>
> the subject of the patch should be
> leds: lm3697: Rename struct into more appropiate name
> ("leds: " is prefixed). Look at history
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/log/drivers/leds?h=v5.9-rc8
>
> The commit message should mention why you are renaming the type
> (something like "to be semantically more correct, since that structure
> represents LED control bank as described by the datasheet").
>
> Also it seems that you are using git format-patch for generating patch
> files, but you are sending these patches as regular e-mail attachements.
> You should instead use git send-email, as is normally required
> for kernel patches (and they would also appear in patchwork
> (https://patches.linaro.org/project/linux-leds/list/). Please look at
> https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html
> and https://git-send-email.io/.
>
> Marek
>
Gabriel
On 10/7/20 7:21 AM, [email protected] wrote:
> The reason I didn't use git send-mail earlier is because Tutanota doesn't supports SMTP and Protonmail requires a paid account for using SMTP/IMAP. However, I made an account creation request for Disroot(which does support SMTP for free), so when/if the account gets created I'll send future patches through there.
> Oct 6, 2020, 23:26 by [email protected]:
>
>
Also please note top posting on emails is not preferred. As you will
find in the LED domain bottom posts and trimming emails to what is being
commented on is preferred.
As demonstrated.
Dan
Gotcha.
From now on I'm gonna respond with this new email: [email protected] .
Oct 7, 2020, 14:56 by [email protected]:
> Gabriel
>
> On 10/7/20 7:21 AM, [email protected] wrote:
>
>> The reason I didn't use git send-mail earlier is because Tutanota doesn't supports SMTP and Protonmail requires a paid account for using SMTP/IMAP. However, I made an account creation request for Disroot(which does support SMTP for free), so when/if the account gets created I'll send future patches through there.
>> Oct 6, 2020, 23:26 by [email protected]:
>>
> Also please note top posting on emails is not preferred. As you will find in the LED domain bottom posts and trimming emails to what is being commented on is preferred.
>
> As demonstrated.
>
> Dan
>
Umm:
<[email protected]>: host vger.kernel.org[23.128.96.18] said: 553
5.7.1 Hello [178.21.23.139], for your MAIL FROM address
<[email protected]> policy analysis reported: Your address is not
liked source for email (in reply to MAIL FROM command)Is disroot.org banned?
Oct 8, 2020, 12:10 by [email protected]:
> Gotcha.
>
> From now on I'm gonna respond with this new email: > [email protected]> .
>
> Oct 7, 2020, 14:56 by [email protected]:
>
>> Gabriel
>>
>> On 10/7/20 7:21 AM, [email protected] wrote:
>>
>>> The reason I didn't use git send-mail earlier is because Tutanota doesn't supports SMTP and Protonmail requires a paid account for using SMTP/IMAP. However, I made an account creation request for Disroot(which does support SMTP for free), so when/if the account gets created I'll send future patches through there.
>>> Oct 6, 2020, 23:26 by [email protected]:
>>>
>> Also please note top posting on emails is not preferred. As you will find in the LED domain bottom posts and trimming emails to what is being commented on is preferred.
>>
>> As demonstrated.
>>
>> Dan
>>
>
>