2006-08-09 03:45:33

by Jeff Garzik

[permalink] [raw]
Subject: Re: lockdep: fix smc91x

Russell King wrote:
> Hi,
>
> When booting using root-nfs, I'm seeing (independently) two lockdep dumps
> in the smc91x driver. The patch below fixes both. Both dumps look like
> real locking issues.
>
> Nico - please review and ack if you think the patch is correct.

Was this ever ACK'd?

I would prefer spin_lock_irqsave(), but that's just a quibble. I would
be OK with applying this.

Jeff



2006-08-09 23:29:26

by Russell King

[permalink] [raw]
Subject: Re: lockdep: fix smc91x

On Tue, Aug 08, 2006 at 11:45:28PM -0400, Jeff Garzik wrote:
> Russell King wrote:
> >Hi,
> >
> >When booting using root-nfs, I'm seeing (independently) two lockdep dumps
> >in the smc91x driver. The patch below fixes both. Both dumps look like
> >real locking issues.
> >
> >Nico - please review and ack if you think the patch is correct.
>
> Was this ever ACK'd?

Not afaik.

> I would prefer spin_lock_irqsave(), but that's just a quibble. I would
> be OK with applying this.

Yes, though I did review all call paths to make sure it was safe first.

--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core