2020-10-16 22:33:30

by Jens Axboe

Subject: dmar compile failure in -git

Hi,

Ran into this one yesterday:

drivers/iommu/intel/dmar.c: In function ‘free_iommu’:
drivers/iommu/intel/dmar.c:1139:41: error: ‘struct iommu_device’ has no member named ‘ops’
1139 | if (intel_iommu_enabled && iommu->iommu.ops) {
| ^
make[3]: *** [scripts/Makefile.build:283: drivers/iommu/intel/dmar.o] Error 1
make[3]: *** Waiting for unfinished jobs....
make[2]: *** [scripts/Makefile.build:500: drivers/iommu/intel] Error 2
make[1]: *** [scripts/Makefile.build:500: drivers/iommu] Error 2
make: *** [Makefile:1777: drivers] Error 2

which is due to the config I use:

axboe@amd ~/g/linux-block (master)> cat .config | grep IOMMU
# CONFIG_GART_IOMMU is not set
CONFIG_IOMMU_SUPPORT=y
# Generic IOMMU Pagetable Support
# end of Generic IOMMU Pagetable Support
# CONFIG_IOMMU_DEBUGFS is not set
# CONFIG_AMD_IOMMU is not set
# CONFIG_INTEL_IOMMU is not set
axboe@amd ~/g/linux-block (master)> cat .config | grep DMAR
CONFIG_DMAR_TABLE=y

--
Jens Axboe

2020-10-17 09:59:47

by David Woodhouse

Subject: Re: dmar compile failure in -git

On 16 October 2020 22:23:46 BST, Jens Axboe <[email protected]> wrote:
>Hi,
>
>Ran into this one yesterday:
>
>drivers/iommu/intel/dmar.c: In function ‘free_iommu’:
>drivers/iommu/intel/dmar.c:1139:41: error: ‘struct iommu_device’ has no
>member named ‘ops’
> 1139 | if (intel_iommu_enabled && iommu->iommu.ops) {
> | ^
>make[3]: *** [scripts/Makefile.build:283: drivers/iommu/intel/dmar.o]
>Error 1
>make[3]: *** Waiting for unfinished jobs....
>make[2]: *** [scripts/Makefile.build:500: drivers/iommu/intel] Error 2
>make[1]: *** [scripts/Makefile.build:500: drivers/iommu] Error 2
>make: *** [Makefile:1777: drivers] Error 2
>
>which is due to the config I use:


Thanks. Should be fixed by https://www.mail-archive.com/[email protected]/msg45697.html

2020-10-21 06:35:08

by Jens Axboe

Subject: Re: dmar compile failure in -git

On Sat, Oct 17, 2020 at 1:03 AM David Woodhouse <[email protected]> wrote:
> On 16 October 2020 22:23:46 BST, Jens Axboe <[email protected]> wrote:
> >Hi,
> >
> >Ran into this one yesterday:
> >
> >drivers/iommu/intel/dmar.c: In function ‘free_iommu’:
> >drivers/iommu/intel/dmar.c:1139:41: error: ‘struct iommu_device’ has no
> >member named ‘ops’
> > 1139 | if (intel_iommu_enabled && iommu->iommu.ops) {
> > | ^
> >make[3]: *** [scripts/Makefile.build:283: drivers/iommu/intel/dmar.o]
> >Error 1
> >make[3]: *** Waiting for unfinished jobs....
> >make[2]: *** [scripts/Makefile.build:500: drivers/iommu/intel] Error 2
> >make[1]: *** [scripts/Makefile.build:500: drivers/iommu] Error 2
> >make: *** [Makefile:1777: drivers] Error 2
> >
> >which is due to the config I use:
>
> Thanks. Should be fixed by
> https://www.mail-archive.com/[email protected]/msg45697.html

Can we please get this known build breakage fix upstream? It keeps
breaking my test box compiles, which is pretty annoying.

--
Jens Axboe

2020-10-21 06:52:52

by Jens Axboe

Subject: Re: dmar compile failure in -git

On 10/20/20 10:26 AM, Jens Axboe wrote:
> On Sat, Oct 17, 2020 at 1:03 AM David Woodhouse <[email protected]> wrote:
>> On 16 October 2020 22:23:46 BST, Jens Axboe <[email protected]> wrote:
>>> Hi,
>>>
>>> Ran into this one yesterday:
>>>
>>> drivers/iommu/intel/dmar.c: In function ‘free_iommu’:
>>> drivers/iommu/intel/dmar.c:1139:41: error: ‘struct iommu_device’ has no
>>> member named ‘ops’
>>> 1139 | if (intel_iommu_enabled && iommu->iommu.ops) {
>>> | ^
>>> make[3]: *** [scripts/Makefile.build:283: drivers/iommu/intel/dmar.o]
>>> Error 1
>>> make[3]: *** Waiting for unfinished jobs....
>>> make[2]: *** [scripts/Makefile.build:500: drivers/iommu/intel] Error 2
>>> make[1]: *** [scripts/Makefile.build:500: drivers/iommu] Error 2
>>> make: *** [Makefile:1777: drivers] Error 2
>>>
>>> which is due to the config I use:
>>
>> Thanks. Should be fixed by
>> https://www.mail-archive.com/[email protected]/msg45697.html
>
> Can we please get this known build breakage fix upstream? It keeps
> breaking my test box compiles, which is pretty annoying.

Nevermind, looks like it went upstream about the same time as I sent
this email. Thanks!

--
Jens Axboe