2020-10-19 12:11:08

by kernel test robot

[permalink] [raw]
Subject: drivers/net/can/spi/mcp251xfd/mcp251xfd-regmap.c:176:2-3: Unneeded semicolon

tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 7cf726a59435301046250c42131554d9ccc566b8
commit: f4f77366f21dfd6ac69a902313367d638b328ba1 can: mcp251xfd: rename all user facing strings to mcp251xfd
date: 3 weeks ago
config: c6x-randconfig-c004-20201019 (attached as .config)
compiler: c6x-elf-gcc (GCC) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>


"coccinelle warnings: (new ones prefixed by >>)"
>> drivers/net/can/spi/mcp251xfd/mcp251xfd-regmap.c:176:2-3: Unneeded semicolon

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email protected]


Attachments:
(No filename) (780.00 B)
.config.gz (23.79 kB)
Download all attachments

2020-10-19 23:00:46

by kernel test robot

[permalink] [raw]
Subject: [PATCH] can: mcp251xfd: fix semicolon.cocci warnings

From: kernel test robot <[email protected]>

drivers/net/can/spi/mcp251xfd/mcp251xfd-regmap.c:176:2-3: Unneeded semicolon


Remove unneeded semicolon.

Generated by: scripts/coccinelle/misc/semicolon.cocci

Fixes: f4f77366f21d ("can: mcp251xfd: rename all user facing strings to mcp251xfd")
Signed-off-by: kernel test robot <[email protected]>
---

tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 7cf726a59435301046250c42131554d9ccc566b8
commit: f4f77366f21dfd6ac69a902313367d638b328ba1 can: mcp251xfd: rename all user facing strings to mcp251xfd

mcp251xfd-regmap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/net/can/spi/mcp251xfd/mcp251xfd-regmap.c
+++ b/drivers/net/can/spi/mcp251xfd/mcp251xfd-regmap.c
@@ -173,7 +173,7 @@ mcp251xfd_regmap_nocrc_read(void *contex
memcpy(&buf_tx->cmd, reg, sizeof(buf_tx->cmd));
if (MCP251XFD_SANITIZE_SPI)
memset(buf_tx->data, 0x0, val_len);
- };
+ }

err = spi_sync(spi, &msg);
if (err)

2020-10-20 09:42:57

by Marc Kleine-Budde

[permalink] [raw]
Subject: Re: [PATCH] can: mcp251xfd: fix semicolon.cocci warnings

On 10/19/20 2:08 PM, kernel test robot wrote:
> From: kernel test robot <[email protected]>
>
> drivers/net/can/spi/mcp251xfd/mcp251xfd-regmap.c:176:2-3: Unneeded semicolon
>
>
> Remove unneeded semicolon.
>
> Generated by: scripts/coccinelle/misc/semicolon.cocci
>
> Fixes: f4f77366f21d ("can: mcp251xfd: rename all user facing strings to mcp251xfd")

The correct fixes tag is:

Fixes: 875347fe5756 ("can: mcp25xxfd: add regmap infrastructure")

> Signed-off-by: kernel test robot <[email protected]>

Applied with that to linux-can.

tnx,
Marc

--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |


Attachments:
signature.asc (499.00 B)
OpenPGP digital signature