2020-11-11 10:39:07

by Jon Hunter

[permalink] [raw]
Subject: [PATCH] phy: tegra: Don't warn on probe deferral

Deferred probe is an expected return value for devm_regulator_bulk_get().
Given that the driver deals with it properly, there's no need to output a
warning that may potentially confuse users.

Signed-off-by: Jon Hunter <[email protected]>
---
drivers/phy/tegra/xusb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/phy/tegra/xusb.c b/drivers/phy/tegra/xusb.c
index ad88d74c1884..2eafb813825b 100644
--- a/drivers/phy/tegra/xusb.c
+++ b/drivers/phy/tegra/xusb.c
@@ -1200,7 +1200,7 @@ static int tegra_xusb_padctl_probe(struct platform_device *pdev)
err = devm_regulator_bulk_get(&pdev->dev, padctl->soc->num_supplies,
padctl->supplies);
if (err < 0) {
- dev_err(&pdev->dev, "failed to get regulators: %d\n", err);
+ dev_err_probe(&pdev->dev, err, "failed to get regulators\n");
goto remove;
}

--
2.25.1


2020-11-13 09:25:36

by JC Kuo

[permalink] [raw]
Subject: Re: [PATCH] phy: tegra: Don't warn on probe deferral

On 11/11/20 6:37 PM, Jon Hunter wrote:
> Deferred probe is an expected return value for devm_regulator_bulk_get().
> Given that the driver deals with it properly, there's no need to output a
> warning that may potentially confuse users.
>
> Signed-off-by: Jon Hunter <[email protected]>
> ---
> drivers/phy/tegra/xusb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/phy/tegra/xusb.c b/drivers/phy/tegra/xusb.c
> index ad88d74c1884..2eafb813825b 100644
> --- a/drivers/phy/tegra/xusb.c
> +++ b/drivers/phy/tegra/xusb.c
> @@ -1200,7 +1200,7 @@ static int tegra_xusb_padctl_probe(struct platform_device *pdev)
> err = devm_regulator_bulk_get(&pdev->dev, padctl->soc->num_supplies,
> padctl->supplies);
> if (err < 0) {
> - dev_err(&pdev->dev, "failed to get regulators: %d\n", err);
> + dev_err_probe(&pdev->dev, err, "failed to get regulators\n");
> goto remove;
> }
>
>
Acked-by: JC Kuo <[email protected]>

2020-11-13 16:15:47

by Thierry Reding

[permalink] [raw]
Subject: Re: [PATCH] phy: tegra: Don't warn on probe deferral

On Wed, Nov 11, 2020 at 10:37:08AM +0000, Jon Hunter wrote:
> Deferred probe is an expected return value for devm_regulator_bulk_get().
> Given that the driver deals with it properly, there's no need to output a
> warning that may potentially confuse users.
>
> Signed-off-by: Jon Hunter <[email protected]>
> ---
> drivers/phy/tegra/xusb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Acked-by: Thierry Reding <[email protected]>

Attachments:
(No filename) (460.00 B)
 signature.asc (849.00 B)
 Download all attachments

2020-11-16 07:53:23

by Vinod Koul

[permalink] [raw]
Subject: Re: [PATCH] phy: tegra: Don't warn on probe deferral

On 11-11-20, 10:37, Jon Hunter wrote:
> Deferred probe is an expected return value for devm_regulator_bulk_get().
> Given that the driver deals with it properly, there's no need to output a
> warning that may potentially confuse users.

Applied, thanks

--
~Vinod