2020-11-17 20:35:57

by Alexandre Belloni

Subject: [PATCH] rtc: mxc: use of_device_get_match_data

Use of_device_get_match_data to simplify mxc_rtc_probe.

Signed-off-by: Alexandre Belloni <[email protected]>
---
drivers/rtc/rtc-mxc.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/rtc/rtc-mxc.c b/drivers/rtc/rtc-mxc.c
index 018bfa952d66..0d253ce3a8f5 100644
--- a/drivers/rtc/rtc-mxc.c
+++ b/drivers/rtc/rtc-mxc.c
@@ -307,14 +307,12 @@ static int mxc_rtc_probe(struct platform_device *pdev)
u32 reg;
unsigned long rate;
int ret;
- const struct of_device_id *of_id;

pdata = devm_kzalloc(&pdev->dev, sizeof(*pdata), GFP_KERNEL);
if (!pdata)
return -ENOMEM;

- of_id = of_match_device(imx_rtc_dt_ids, &pdev->dev);
- pdata->devtype = (enum imx_rtc_type)of_id->data;
+ pdata->devtype = (enum imx_rtc_type)of_device_get_match_data(&pdev->dev);

pdata->ioaddr = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(pdata->ioaddr))
--
2.28.0

2020-11-17 20:45:07

by Fabio Estevam

Subject: Re: [PATCH] rtc: mxc: use of_device_get_match_data

On Tue, Nov 17, 2020 at 5:30 PM Alexandre Belloni
<[email protected]> wrote:
>
> Use of_device_get_match_data to simplify mxc_rtc_probe.
>
> Signed-off-by: Alexandre Belloni <[email protected]>

Reviewed-by: Fabio Estevam <[email protected]>