2020-12-10 12:01:08

by Tian Tao

Subject: [PATCH] phy: cpcap-usb: remove unneeded conversion to bool

Fix the following warning:
drivers/phy/motorola/phy-cpcap-usb.c:146:31-36: WARNING: conversion to
bool not needed here.

Signed-off-by: Tian Tao <[email protected]>
---
drivers/phy/motorola/phy-cpcap-usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/phy/motorola/phy-cpcap-usb.c b/drivers/phy/motorola/phy-cpcap-usb.c
index 442522b..c276f7c 100644
--- a/drivers/phy/motorola/phy-cpcap-usb.c
+++ b/drivers/phy/motorola/phy-cpcap-usb.c
@@ -143,7 +143,7 @@ static bool cpcap_usb_vbus_valid(struct cpcap_phy_ddata *ddata)

error = iio_read_channel_processed(ddata->vbus, &value);
if (error >= 0)
- return value > 3900 ? true : false;
+ return value > 3900;

dev_err(ddata->dev, "error reading VBUS: %i\n", error);

--
2.7.4

2021-01-13 11:52:17

by Vinod Koul

Subject: Re: [PATCH] phy: cpcap-usb: remove unneeded conversion to bool

On 10-12-20, 19:11, Tian Tao wrote:
> Fix the following warning:
> drivers/phy/motorola/phy-cpcap-usb.c:146:31-36: WARNING: conversion to
> bool not needed here.

Applied, thanks

--
~Vinod