2021-01-16 03:35:51

by Randy Dunlap

Subject: [PATCH] imx: select SOC_BUS to fix firmware build

Fix build error in firmware/imx/ selecting SOC_BUS.

riscv32-linux-ld: drivers/firmware/imx/imx-scu-soc.o: in function `.L9':
imx-scu-soc.c:(.text+0x1b0): undefined reference to `soc_device_register'

Fixes: edbee095fafb ("firmware: imx: add SCU firmware driver support")
Signed-off-by: Randy Dunlap <[email protected]>
Reported-by: kernel test robot <[email protected]>
Cc: Atish Patra <[email protected]>
Cc: Palmer Dabbelt <[email protected]>
Cc: Ard Biesheuvel <[email protected]>
Cc: Anson Huang <[email protected]>
Cc: Daniel Baluta <[email protected]>
Cc: Shawn Guo <[email protected]>
Cc: Dong Aisheng <[email protected]>
---
drivers/firmware/imx/Kconfig | 1 +
1 file changed, 1 insertion(+)

--- linux-next-20210115.orig/drivers/firmware/imx/Kconfig
+++ linux-next-20210115/drivers/firmware/imx/Kconfig
@@ -13,6 +13,7 @@ config IMX_DSP
config IMX_SCU
bool "IMX SCU Protocol driver"
depends on IMX_MBOX
+ select SOC_BUS
help
The System Controller Firmware (SCFW) is a low-level system function
which runs on a dedicated Cortex-M core to provide power, clock, and

2021-01-18 04:41:59

by Aisheng Dong

Subject: RE: [PATCH] imx: select SOC_BUS to fix firmware build

> From: Randy Dunlap <[email protected]>
> Sent: Saturday, January 16, 2021 11:33 AM
> Subject: [PATCH] imx: select SOC_BUS to fix firmware build

Patch title probably is better to be:
firmware: imx: xxxxx

Otherwise:
Reviewed-by: Dong Aisheng <[email protected]>

Regards
Aisheng

>
> Fix build error in firmware/imx/ selecting SOC_BUS.
>
> riscv32-linux-ld: drivers/firmware/imx/imx-scu-soc.o: in function `.L9':
> imx-scu-soc.c:(.text+0x1b0): undefined reference to `soc_device_register'
>
> Fixes: edbee095fafb ("firmware: imx: add SCU firmware driver support")
> Signed-off-by: Randy Dunlap <[email protected]>
> Reported-by: kernel test robot <[email protected]>
> Cc: Atish Patra <[email protected]>
> Cc: Palmer Dabbelt <[email protected]>
> Cc: Ard Biesheuvel <[email protected]>
> Cc: Anson Huang <[email protected]>
> Cc: Daniel Baluta <[email protected]>
> Cc: Shawn Guo <[email protected]>
> Cc: Dong Aisheng <[email protected]>
> ---
> drivers/firmware/imx/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-next-20210115.orig/drivers/firmware/imx/Kconfig
> +++ linux-next-20210115/drivers/firmware/imx/Kconfig
> @@ -13,6 +13,7 @@ config IMX_DSP
> config IMX_SCU
> bool "IMX SCU Protocol driver"
> depends on IMX_MBOX
> + select SOC_BUS
> help
> The System Controller Firmware (SCFW) is a low-level system function
> which runs on a dedicated Cortex-M core to provide power, clock, and

2021-01-18 23:13:47

by Shawn Guo

Subject: Re: [PATCH] imx: select SOC_BUS to fix firmware build

On Mon, Jan 18, 2021 at 04:36:55AM +0000, Aisheng Dong wrote:
> > From: Randy Dunlap <[email protected]>
> > Sent: Saturday, January 16, 2021 11:33 AM
> > Subject: [PATCH] imx: select SOC_BUS to fix firmware build
>
> Patch title probably is better to be:
> firmware: imx: xxxxx

Fixed it up and applied.