2021-01-23 14:32:44

by Paul Cercueil

Subject: [PATCH] remoteproc: ingenic: Add module parameter 'auto_boot'

Add a 'auto_boot' module parameter that instructs the remoteproc driver
whether or not it should auto-boot the remote processor, which will
default to "false", since the VPU in Ingenic SoCs does not really have
any predetermined function.

Signed-off-by: Paul Cercueil <[email protected]>
---
drivers/remoteproc/ingenic_rproc.c | 7 +++++++
1 file changed, 7 insertions(+)

diff --git a/drivers/remoteproc/ingenic_rproc.c b/drivers/remoteproc/ingenic_rproc.c
index 26e19e6143b7..e2618c36eaab 100644
--- a/drivers/remoteproc/ingenic_rproc.c
+++ b/drivers/remoteproc/ingenic_rproc.c
@@ -27,6 +27,11 @@
#define AUX_CTRL_NMI BIT(1)
#define AUX_CTRL_SW_RESET BIT(0)

+static bool auto_boot;
+module_param(auto_boot, bool, 0400);
+MODULE_PARM_DESC(auto_boot,
+ "Auto-boot the remote processor [default=false]");
+
struct vpu_mem_map {
const char *name;
unsigned int da;
@@ -172,6 +177,8 @@ static int ingenic_rproc_probe(struct platform_device *pdev)
if (!rproc)
return -ENOMEM;

+ rproc->auto_boot = auto_boot;
+
vpu = rproc->priv;
vpu->dev = &pdev->dev;
platform_set_drvdata(pdev, vpu);
--
2.29.2

2021-01-27 23:58:58

by Mathieu Poirier

Subject: Re: [PATCH] remoteproc: ingenic: Add module parameter 'auto_boot'

On Sat, Jan 23, 2021 at 02:29:56PM +0000, Paul Cercueil wrote:
> Add a 'auto_boot' module parameter that instructs the remoteproc driver
> whether or not it should auto-boot the remote processor, which will
> default to "false", since the VPU in Ingenic SoCs does not really have
> any predetermined function.
>
> Signed-off-by: Paul Cercueil <[email protected]>
> ---
> drivers/remoteproc/ingenic_rproc.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/remoteproc/ingenic_rproc.c b/drivers/remoteproc/ingenic_rproc.c
> index 26e19e6143b7..e2618c36eaab 100644
> --- a/drivers/remoteproc/ingenic_rproc.c
> +++ b/drivers/remoteproc/ingenic_rproc.c
> @@ -27,6 +27,11 @@
> #define AUX_CTRL_NMI BIT(1)
> #define AUX_CTRL_SW_RESET BIT(0)
>
> +static bool auto_boot;
> +module_param(auto_boot, bool, 0400);
> +MODULE_PARM_DESC(auto_boot,
> + "Auto-boot the remote processor [default=false]");
> +
> struct vpu_mem_map {
> const char *name;
> unsigned int da;
> @@ -172,6 +177,8 @@ static int ingenic_rproc_probe(struct platform_device *pdev)
> if (!rproc)
> return -ENOMEM;
>
> + rproc->auto_boot = auto_boot;
> +

Reviewed-by: Mathieu Poirier <[email protected]>

> vpu = rproc->priv;
> vpu->dev = &pdev->dev;
> platform_set_drvdata(pdev, vpu);
> --
> 2.29.2
>