2021-02-25 13:46:28

by Arnd Bergmann

Subject: [PATCH] rtc: tps65910: include linux/property.h

From: Arnd Bergmann <[email protected]>

The added device_property_present() call causes a build
failure in some configurations because of the missing header:

drivers/rtc/rtc-tps65910.c:422:7: error: implicit declaration of function 'device_property_present' [-Werror,-Wimplicit-function-declaration]

Fixes: 454ba154a62c ("rtc: tps65910: Support wakeup-source property")
Signed-off-by: Arnd Bergmann <[email protected]>
---
drivers/rtc/rtc-tps65910.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/rtc/rtc-tps65910.c b/drivers/rtc/rtc-tps65910.c
index 288abb1abdb8..bc89c62ccb9b 100644
--- a/drivers/rtc/rtc-tps65910.c
+++ b/drivers/rtc/rtc-tps65910.c
@@ -18,6 +18,7 @@
#include <linux/rtc.h>
#include <linux/bcd.h>
#include <linux/math64.h>
+#include <linux/property.h>
#include <linux/platform_device.h>
#include <linux/interrupt.h>
#include <linux/mfd/tps65910.h>
--
2.29.2

2021-02-27 08:10:56

by Dmitry Osipenko

Subject: Re: [PATCH] rtc: tps65910: include linux/property.h

25.02.2021 16:42, Arnd Bergmann пишет:
> From: Arnd Bergmann <[email protected]>
>
> The added device_property_present() call causes a build
> failure in some configurations because of the missing header:
>
> drivers/rtc/rtc-tps65910.c:422:7: error: implicit declaration of function 'device_property_present' [-Werror,-Wimplicit-function-declaration]
>
> Fixes: 454ba154a62c ("rtc: tps65910: Support wakeup-source property")
> Signed-off-by: Arnd Bergmann <[email protected]>
> ---
> drivers/rtc/rtc-tps65910.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/rtc/rtc-tps65910.c b/drivers/rtc/rtc-tps65910.c
> index 288abb1abdb8..bc89c62ccb9b 100644
> --- a/drivers/rtc/rtc-tps65910.c
> +++ b/drivers/rtc/rtc-tps65910.c
> @@ -18,6 +18,7 @@
> #include <linux/rtc.h>
> #include <linux/bcd.h>
> #include <linux/math64.h>
> +#include <linux/property.h>
> #include <linux/platform_device.h>
> #include <linux/interrupt.h>
> #include <linux/mfd/tps65910.h>
>

Reviewed-by: Dmitry Osipenko <[email protected]>

2021-03-15 22:03:17

by Alexandre Belloni

Subject: Re: [PATCH] rtc: tps65910: include linux/property.h

On Thu, 25 Feb 2021 14:42:04 +0100, Arnd Bergmann wrote:
> The added device_property_present() call causes a build
> failure in some configurations because of the missing header:
>
> drivers/rtc/rtc-tps65910.c:422:7: error: implicit declaration of function 'device_property_present' [-Werror,-Wimplicit-function-declaration]

Applied, thanks!

[1/1] rtc: tps65910: include linux/property.h
commit: 936d3685e62436a378f02b8b74759b054d4aeca1

Best regards,
--
Alexandre Belloni <[email protected]>