2021-03-04 23:21:41

by Colin King

Subject: [PATCH][next] drm/amdgpu/display: remove redundant continue statement

From: Colin Ian King <[email protected]>

The continue statement in a for-loop is redudant and can be removed.
Clean up the code to address this.

Addresses-Coverity: ("Continue as no effect")
Fixes: b6f91fc183f7 ("drm/amdgpu/display: buffer INTERRUPT_LOW_IRQ_CONTEXT interrupt work")
Signed-off-by: Colin Ian King <[email protected]>
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_irq.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_irq.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_irq.c
index 8ce10d0973c5..d3c687d07ee6 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_irq.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_irq.c
@@ -520,9 +520,7 @@ static void amdgpu_dm_irq_schedule_work(struct amdgpu_device *adev,
return;

list_for_each_entry (handler_data, handler_list, list) {
- if (!queue_work(system_highpri_wq, &handler_data->work)) {
- continue;
- } else {
+ if (queue_work(system_highpri_wq, &handler_data->work)) {
work_queued = true;
break;
}
--
2.30.0

2021-03-05 19:11:43

by Alex Deucher

Subject: Re: [PATCH][next] drm/amdgpu/display: remove redundant continue statement

Applied. thanks.

Alex

On Wed, Mar 3, 2021 at 8:25 AM Colin King <[email protected]> wrote:
>
> From: Colin Ian King <[email protected]>
>
> The continue statement in a for-loop is redudant and can be removed.
> Clean up the code to address this.
>
> Addresses-Coverity: ("Continue as no effect")
> Fixes: b6f91fc183f7 ("drm/amdgpu/display: buffer INTERRUPT_LOW_IRQ_CONTEXT interrupt work")
> Signed-off-by: Colin Ian King <[email protected]>
> ---
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_irq.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_irq.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_irq.c
> index 8ce10d0973c5..d3c687d07ee6 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_irq.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_irq.c
> @@ -520,9 +520,7 @@ static void amdgpu_dm_irq_schedule_work(struct amdgpu_device *adev,
> return;
>
> list_for_each_entry (handler_data, handler_list, list) {
> - if (!queue_work(system_highpri_wq, &handler_data->work)) {
> - continue;
> - } else {
> + if (queue_work(system_highpri_wq, &handler_data->work)) {
> work_queued = true;
> break;
> }
> --
> 2.30.0
>
> _______________________________________________
> dri-devel mailing list
> [email protected]
> https://lists.freedesktop.org/mailman/listinfo/dri-devel