2021-03-11 10:14:35

by Jiapeng Chong

[permalink] [raw]
Subject: [PATCH] ataflop: fix warning comparing pointer to 0

Fix the following coccicheck warning:

./drivers/block/ataflop.c:1440:20-21: WARNING comparing pointer to 0.

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
drivers/block/ataflop.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/block/ataflop.c b/drivers/block/ataflop.c
index 104b713f4..995374c 100644
--- a/drivers/block/ataflop.c
+++ b/drivers/block/ataflop.c
@@ -1436,8 +1436,7 @@ static int floppy_revalidate(struct gendisk *disk)
unsigned int drive = p - unit;

if (test_bit(drive, &changed_floppies) ||
- test_bit(drive, &fake_change) ||
- p->disktype == 0) {
+ test_bit(drive, &fake_change) || !p->disktype) {
if (UD.flags & FTD_MSG)
printk(KERN_ERR "floppy: clear format %p!\n", UDT);
BufferDrive = -1;
--
1.8.3.1