2021-03-16 13:28:27

by Jiapeng Chong

Subject: [PATCH] scsi: bfa: fix warning comparing pointer to 0

Fix the following coccicheck warning:

./drivers/scsi/bfa/bfad_bsg.c:3412:29-30: WARNING comparing pointer to
0.

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
drivers/scsi/bfa/bfad_bsg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/bfa/bfad_bsg.c b/drivers/scsi/bfa/bfad_bsg.c
index fc51542..be8dfbe 100644
--- a/drivers/scsi/bfa/bfad_bsg.c
+++ b/drivers/scsi/bfa/bfad_bsg.c
@@ -3409,7 +3409,7 @@

drv_fcxp->port = fcs_port->bfad_port;

- if (drv_fcxp->port->bfad == 0)
+ if (!drv_fcxp->port->bfad)
drv_fcxp->port->bfad = bfad;

/* Fetch the bfa_rport - if nexus needed */
--
1.8.3.1

2021-03-30 03:56:50

by Martin K. Petersen

Subject: Re: [PATCH] scsi: bfa: fix warning comparing pointer to 0

On Tue, 16 Mar 2021 15:48:50 +0800, Jiapeng Chong wrote:

> Fix the following coccicheck warning:
>
> ./drivers/scsi/bfa/bfad_bsg.c:3412:29-30: WARNING comparing pointer to
> 0.

Applied to 5.13/scsi-queue, thanks!

[1/1] scsi: bfa: fix warning comparing pointer to 0
https://git.kernel.org/mkp/scsi/c/1630e752fb83

--
Martin K. Petersen Oracle Linux Engineering