2021-03-23 22:22:43

by Randy Dunlap

Subject: [PATCH] linux/gpio/driver.h: some edits for clarity

Fix a few typos and some punctuation.
Also, change CONFIG_OF to CONFIG_OF_GPIO in one comment.

Signed-off-by: Randy Dunlap <[email protected]>
Cc: Linus Walleij <[email protected]>
Cc: Bartosz Golaszewski <[email protected]>
Cc: [email protected]
---
include/linux/gpio/driver.h | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)

--- linux-next-20210323.orig/include/linux/gpio/driver.h
+++ linux-next-20210323/include/linux/gpio/driver.h
@@ -227,7 +227,7 @@ struct gpio_irq_chip {
/**
* @valid_mask:
*
- * If not %NULL holds bitmask of GPIOs which are valid to be included
+ * If not %NULL, holds bitmask of GPIOs which are valid to be included
* in IRQ domain of the chip.
*/
unsigned long *valid_mask;
@@ -346,7 +346,7 @@ struct gpio_irq_chip {
* output.
*
* A gpio_chip can help platforms abstract various sources of GPIOs so
- * they can all be accessed through a common programing interface.
+ * they can all be accessed through a common programming interface.
* Example sources would be SOC controllers, FPGAs, multifunction
* chips, dedicated GPIO expanders, and so on.
*
@@ -435,15 +435,15 @@ struct gpio_chip {
/**
* @valid_mask:
*
- * If not %NULL holds bitmask of GPIOs which are valid to be used
+ * If not %NULL, holds bitmask of GPIOs which are valid to be used
* from the chip.
*/
unsigned long *valid_mask;

#if defined(CONFIG_OF_GPIO)
/*
- * If CONFIG_OF is enabled, then all GPIO controllers described in the
- * device tree automatically may have an OF translation
+ * If CONFIG_OF_GPIO is enabled, then all GPIO controllers described in
+ * the device tree automatically may have an OF translation
*/

/**
@@ -508,7 +508,7 @@ extern int gpiochip_add_data_with_key(st
* for GPIOs will fail rudely.
*
* gpiochip_add_data() must only be called after gpiolib initialization,
- * ie after core_initcall().
+ * i.e. after core_initcall().
*
* If gc->base is negative, this requests dynamic assignment of
* a range of valid GPIOs.

2021-03-25 08:05:08

by Linus Walleij

Subject: Re: [PATCH] linux/gpio/driver.h: some edits for clarity

On Tue, Mar 23, 2021 at 11:19 PM Randy Dunlap <[email protected]> wrote:

> Fix a few typos and some punctuation.
> Also, change CONFIG_OF to CONFIG_OF_GPIO in one comment.
>
> Signed-off-by: Randy Dunlap <[email protected]>
> Cc: Linus Walleij <[email protected]>
> Cc: Bartosz Golaszewski <[email protected]>
> Cc: [email protected]

Reviewed-by: Linus Walleij <[email protected]>

Yours,
Linus Walleij

2021-03-26 13:08:24

by Bartosz Golaszewski

Subject: Re: [PATCH] linux/gpio/driver.h: some edits for clarity

On Tue, Mar 23, 2021 at 11:19 PM Randy Dunlap <[email protected]> wrote:
>
> Fix a few typos and some punctuation.
> Also, change CONFIG_OF to CONFIG_OF_GPIO in one comment.
>
> Signed-off-by: Randy Dunlap <[email protected]>
> Cc: Linus Walleij <[email protected]>
> Cc: Bartosz Golaszewski <[email protected]>
> Cc: [email protected]
> ---

Applied with a slightly improved commit message.

Bartosz