2021-03-25 11:40:09

by Jiabing Wan

Subject: [PATCH] [v3] drivers: watchdog: Remove duplicate include of kernel.h

linux/kernel.h has been included. Remove the duplicate.
Reorder include files to be in alphabetic order.

Signed-off-by: Wan Jiabing <[email protected]>
---
Changelog:
v3:
- Reorder include files to be in alphabetic order.

v2:
- Remove the duplicate which won't make worse.
---
drivers/watchdog/dw_wdt.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/drivers/watchdog/dw_wdt.c b/drivers/watchdog/dw_wdt.c
index 32d0e1781e63..cd578843277e 100644
--- a/drivers/watchdog/dw_wdt.c
+++ b/drivers/watchdog/dw_wdt.c
@@ -13,22 +13,21 @@
*/

#include <linux/bitops.h>
-#include <linux/limits.h>
-#include <linux/kernel.h>
#include <linux/clk.h>
+#include <linux/debugfs.h>
#include <linux/delay.h>
#include <linux/err.h>
+#include <linux/interrupt.h>
#include <linux/io.h>
#include <linux/kernel.h>
+#include <linux/limits.h>
#include <linux/module.h>
#include <linux/moduleparam.h>
-#include <linux/interrupt.h>
#include <linux/of.h>
-#include <linux/pm.h>
#include <linux/platform_device.h>
+#include <linux/pm.h>
#include <linux/reset.h>
#include <linux/watchdog.h>
-#include <linux/debugfs.h>

#define WDOG_CONTROL_REG_OFFSET 0x00
#define WDOG_CONTROL_REG_WDT_EN_MASK 0x01
--
2.25.1

2021-03-25 14:38:44

by Guenter Roeck

Subject: Re: [PATCH] [v3] drivers: watchdog: Remove duplicate include of kernel.h

On 3/25/21 4:29 AM, Wan Jiabing wrote:
> linux/kernel.h has been included. Remove the duplicate.
> Reorder include files to be in alphabetic order.
>
> Signed-off-by: Wan Jiabing <[email protected]>

Reviewed-by: Guenter Roeck <[email protected]>

> ---
> Changelog:
> v3:
> - Reorder include files to be in alphabetic order.
>
> v2:
> - Remove the duplicate which won't make worse.
> ---
> drivers/watchdog/dw_wdt.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/watchdog/dw_wdt.c b/drivers/watchdog/dw_wdt.c
> index 32d0e1781e63..cd578843277e 100644
> --- a/drivers/watchdog/dw_wdt.c
> +++ b/drivers/watchdog/dw_wdt.c
> @@ -13,22 +13,21 @@
> */
>
> #include <linux/bitops.h>
> -#include <linux/limits.h>
> -#include <linux/kernel.h>
> #include <linux/clk.h>
> +#include <linux/debugfs.h>
> #include <linux/delay.h>
> #include <linux/err.h>
> +#include <linux/interrupt.h>
> #include <linux/io.h>
> #include <linux/kernel.h>
> +#include <linux/limits.h>
> #include <linux/module.h>
> #include <linux/moduleparam.h>
> -#include <linux/interrupt.h>
> #include <linux/of.h>
> -#include <linux/pm.h>
> #include <linux/platform_device.h>
> +#include <linux/pm.h>
> #include <linux/reset.h>
> #include <linux/watchdog.h>
> -#include <linux/debugfs.h>
>
> #define WDOG_CONTROL_REG_OFFSET 0x00
> #define WDOG_CONTROL_REG_WDT_EN_MASK 0x01
>