2021-03-25 11:50:00

by Zou Wei

[permalink] [raw]
Subject: [PATCH -next] agp: uninorth: Make some symbols static

The sparse tool complains as follows:

drivers/char/agp/uninorth-agp.c:510:32: warning:
symbol 'uninorth_agp_driver' was not declared. Should it be static?
drivers/char/agp/uninorth-agp.c:538:32: warning:
symbol 'u3_agp_driver' was not declared. Should it be static?

This symbol is not used outside of uninorth-agp.c, so this
commit marks it static.

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Zou Wei <[email protected]>
---
drivers/char/agp/uninorth-agp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/char/agp/uninorth-agp.c b/drivers/char/agp/uninorth-agp.c
index 62de7f4..06db04c 100644
--- a/drivers/char/agp/uninorth-agp.c
+++ b/drivers/char/agp/uninorth-agp.c
@@ -507,7 +507,7 @@ static const struct aper_size_info_32 u3_sizes[] =
{4, 1024, 0, 1}
};

-const struct agp_bridge_driver uninorth_agp_driver = {
+static const struct agp_bridge_driver uninorth_agp_driver = {
.owner = THIS_MODULE,
.aperture_sizes = (void *)uninorth_sizes,
.size_type = U32_APER_SIZE,
@@ -535,7 +535,7 @@ const struct agp_bridge_driver uninorth_agp_driver = {
.needs_scratch_page = true,
};

-const struct agp_bridge_driver u3_agp_driver = {
+static const struct agp_bridge_driver u3_agp_driver = {
.owner = THIS_MODULE,
.aperture_sizes = (void *)u3_sizes,
.size_type = U32_APER_SIZE,
--
2.6.2