2021-04-06 15:38:08

by Jiabing Wan

Subject: [PATCH] drivers: mtd: ubi: Remove unnecessary struct declaration

struct ubi_wl_entry is defined at 178th line.
The declaration here is unnecessary. Remove it.

Signed-off-by: Wan Jiabing <[email protected]>
---
drivers/mtd/ubi/ubi.h | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/mtd/ubi/ubi.h b/drivers/mtd/ubi/ubi.h
index c2da77163f94..7c083ad58274 100644
--- a/drivers/mtd/ubi/ubi.h
+++ b/drivers/mtd/ubi/ubi.h
@@ -388,8 +388,6 @@ struct ubi_volume_desc {
int mode;
};

-struct ubi_wl_entry;
-
/**
* struct ubi_debug_info - debugging information for an UBI device.
*
--
2.25.1

2021-04-06 16:08:33

by Tudor Ambarus

Subject: Re: [PATCH] drivers: mtd: ubi: Remove unnecessary struct declaration

On 4/6/21 9:37 AM, Wan Jiabing wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> struct ubi_wl_entry is defined at 178th line.
> The declaration here is unnecessary. Remove it.
>
> Signed-off-by: Wan Jiabing <[email protected]>

the subject of the patch should start with "ubi:", thus
"ubi: Remove unnecessary struct declaration"

with that:
Reviewed-by: Tudor Ambarus <[email protected]>

> ---
> drivers/mtd/ubi/ubi.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/mtd/ubi/ubi.h b/drivers/mtd/ubi/ubi.h
> index c2da77163f94..7c083ad58274 100644
> --- a/drivers/mtd/ubi/ubi.h
> +++ b/drivers/mtd/ubi/ubi.h
> @@ -388,8 +388,6 @@ struct ubi_volume_desc {
> int mode;
> };
>
> -struct ubi_wl_entry;
> -
> /**
> * struct ubi_debug_info - debugging information for an UBI device.
> *
> --
> 2.25.1
>
>
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/
>