LinuxLists.cc - [PATCH] media: dt-bindings: media: renesas,drif: Fix fck definition

2021-04-08 20:25:48

Subject: [PATCH] media: dt-bindings: media: renesas,drif: Fix fck definition

dt_binding_check reports the below error with the latest schema:

Documentation/devicetree/bindings/media/renesas,drif.yaml:
properties:clock-names:maxItems: False schema does not allow 1
Documentation/devicetree/bindings/media/renesas,drif.yaml:
ignoring, error in schema: properties: clock-names: maxItems

This patch fixes the problem.

Signed-off-by: Fabrizio Castro <[email protected]>
---
Documentation/devicetree/bindings/media/renesas,drif.yaml | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/media/renesas,drif.yaml b/Documentation/devicetree/bindings/media/renesas,drif.yaml
index f1bdaeab4053..e28396f35ee6 100644
--- a/Documentation/devicetree/bindings/media/renesas,drif.yaml
+++ b/Documentation/devicetree/bindings/media/renesas,drif.yaml
@@ -67,9 +67,7 @@ properties:
maxItems: 1

clock-names:
- maxItems: 1
- items:
- - const: fck
+ const: fck

resets:
maxItems: 1
--
2.25.1

2021-04-09 18:55:14

by Rob Herring (Arm)

[permalink] [raw]

Subject: Re: [PATCH] media: dt-bindings: media: renesas,drif: Fix fck definition

On Thu, 08 Apr 2021 21:24:36 +0100, Fabrizio Castro wrote:
> dt_binding_check reports the below error with the latest schema:
>
> Documentation/devicetree/bindings/media/renesas,drif.yaml:
> properties:clock-names:maxItems: False schema does not allow 1
> Documentation/devicetree/bindings/media/renesas,drif.yaml:
> ignoring, error in schema: properties: clock-names: maxItems
>
> This patch fixes the problem.
>
> Signed-off-by: Fabrizio Castro <[email protected]>
> ---
> Documentation/devicetree/bindings/media/renesas,drif.yaml | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>

Reviewed-by: Rob Herring <[email protected]>

2021-04-27 18:04:52

by Rob Herring

[permalink] [raw]

Subject: Re: [PATCH] media: dt-bindings: media: renesas,drif: Fix fck definition

On Fri, Apr 9, 2021 at 1:54 PM Rob Herring <[email protected]> wrote:
>
> On Thu, 08 Apr 2021 21:24:36 +0100, Fabrizio Castro wrote:
> > dt_binding_check reports the below error with the latest schema:
> >
> > Documentation/devicetree/bindings/media/renesas,drif.yaml:
> > properties:clock-names:maxItems: False schema does not allow 1
> > Documentation/devicetree/bindings/media/renesas,drif.yaml:
> > ignoring, error in schema: properties: clock-names: maxItems
> >
> > This patch fixes the problem.
> >
> > Signed-off-by: Fabrizio Castro <[email protected]>
> > ---
> > Documentation/devicetree/bindings/media/renesas,drif.yaml | 4 +---
> > 1 file changed, 1 insertion(+), 3 deletions(-)
> >
>
> Reviewed-by: Rob Herring <[email protected]>

Still failing in linux-next...

Rob

2021-04-27 20:12:15

by Laurent Pinchart

[permalink] [raw]

Subject: Re: [PATCH] media: dt-bindings: media: renesas,drif: Fix fck definition

Hi Rob,

On Tue, Apr 27, 2021 at 01:02:57PM -0500, Rob Herring wrote:
> On Fri, Apr 9, 2021 at 1:54 PM Rob Herring wrote:
> > On Thu, 08 Apr 2021 21:24:36 +0100, Fabrizio Castro wrote:
> > > dt_binding_check reports the below error with the latest schema:
> > >
> > > Documentation/devicetree/bindings/media/renesas,drif.yaml:
> > > properties:clock-names:maxItems: False schema does not allow 1
> > > Documentation/devicetree/bindings/media/renesas,drif.yaml:
> > > ignoring, error in schema: properties: clock-names: maxItems
> > >
> > > This patch fixes the problem.
> > >
> > > Signed-off-by: Fabrizio Castro <[email protected]>
> > > ---
> > > Documentation/devicetree/bindings/media/renesas,drif.yaml | 4 +---
> > > 1 file changed, 1 insertion(+), 3 deletions(-)
> > >
> >
> > Reviewed-by: Rob Herring <[email protected]>
>
> Still failing in linux-next...

Sorry, as a standalone fix, I incorrectly thought you'd merge it.

Reviewed-by: Laurent Pinchart <[email protected]>

and applied to my tree. I'll send a pull request to linux-media when the
merge window closes.

--
Regards,

Laurent Pinchart

2021-06-04 19:41:54

by Rob Herring

[permalink] [raw]

Subject: Re: [PATCH] media: dt-bindings: media: renesas,drif: Fix fck definition

On Tue, Apr 27, 2021 at 3:08 PM Laurent Pinchart
<[email protected]> wrote:
>
> Hi Rob,
>
> On Tue, Apr 27, 2021 at 01:02:57PM -0500, Rob Herring wrote:
> > On Fri, Apr 9, 2021 at 1:54 PM Rob Herring wrote:
> > > On Thu, 08 Apr 2021 21:24:36 +0100, Fabrizio Castro wrote:
> > > > dt_binding_check reports the below error with the latest schema:
> > > >
> > > > Documentation/devicetree/bindings/media/renesas,drif.yaml:
> > > > properties:clock-names:maxItems: False schema does not allow 1
> > > > Documentation/devicetree/bindings/media/renesas,drif.yaml:
> > > > ignoring, error in schema: properties: clock-names: maxItems
> > > >
> > > > This patch fixes the problem.
> > > >
> > > > Signed-off-by: Fabrizio Castro <[email protected]>
> > > > ---
> > > > Documentation/devicetree/bindings/media/renesas,drif.yaml | 4 +---
> > > > 1 file changed, 1 insertion(+), 3 deletions(-)
> > > >
> > >
> > > Reviewed-by: Rob Herring <[email protected]>
> >
> > Still failing in linux-next...
>
> Sorry, as a standalone fix, I incorrectly thought you'd merge it.
>
> Reviewed-by: Laurent Pinchart <[email protected]>
>
> and applied to my tree. I'll send a pull request to linux-media when the
> merge window closes.

Still failing in linux-next. It's also a failure in Linus' tree, so it
needs to go in as a fix.

Rob

2021-06-04 22:07:29

by Laurent Pinchart

[permalink] [raw]

Subject: Re: [PATCH] media: dt-bindings: media: renesas,drif: Fix fck definition

Hi Rob,

On Fri, Jun 04, 2021 at 02:38:36PM -0500, Rob Herring wrote:
> On Tue, Apr 27, 2021 at 3:08 PM Laurent Pinchart wrote:
> > On Tue, Apr 27, 2021 at 01:02:57PM -0500, Rob Herring wrote:
> > > On Fri, Apr 9, 2021 at 1:54 PM Rob Herring wrote:
> > > > On Thu, 08 Apr 2021 21:24:36 +0100, Fabrizio Castro wrote:
> > > > > dt_binding_check reports the below error with the latest schema:
> > > > >
> > > > > Documentation/devicetree/bindings/media/renesas,drif.yaml:
> > > > > properties:clock-names:maxItems: False schema does not allow 1
> > > > > Documentation/devicetree/bindings/media/renesas,drif.yaml:
> > > > > ignoring, error in schema: properties: clock-names: maxItems
> > > > >
> > > > > This patch fixes the problem.
> > > > >
> > > > > Signed-off-by: Fabrizio Castro <[email protected]>
> > > > > ---
> > > > > Documentation/devicetree/bindings/media/renesas,drif.yaml | 4 +---
> > > > > 1 file changed, 1 insertion(+), 3 deletions(-)
> > > > >
> > > >
> > > > Reviewed-by: Rob Herring <[email protected]>
> > >
> > > Still failing in linux-next...
> >
> > Sorry, as a standalone fix, I incorrectly thought you'd merge it.
> >
> > Reviewed-by: Laurent Pinchart <[email protected]>
> >
> > and applied to my tree. I'll send a pull request to linux-media when the
> > merge window closes.
>
> Still failing in linux-next. It's also a failure in Linus' tree, so it
> needs to go in as a fix.

Sorry, been overwhelmed. Feel free to take the patch through your tree
as a fix.

--
Regards,

Laurent Pinchart

2021-06-09 17:01:49

by Rob Herring (Arm)

[permalink] [raw]