2021-04-13 08:58:03

by Jiapeng Chong

Subject: [PATCH] hwmon: (nct6683) remove useless function

Fix the following clang warning:

drivers/hwmon/nct6683.c:491:19: warning: unused function 'in_to_reg'
[-Wunused-function].

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
drivers/hwmon/nct6683.c | 11 -----------
1 file changed, 11 deletions(-)

diff --git a/drivers/hwmon/nct6683.c b/drivers/hwmon/nct6683.c
index a23047a..b886cf0 100644
--- a/drivers/hwmon/nct6683.c
+++ b/drivers/hwmon/nct6683.c
@@ -488,17 +488,6 @@ static inline long in_from_reg(u16 reg, u8 src)
return reg * scale;
}

-static inline u16 in_to_reg(u32 val, u8 src)
-{
- int scale = 16;
-
- if (src == MON_SRC_VCC || src == MON_SRC_VSB || src == MON_SRC_AVSB ||
- src == MON_SRC_VBAT)
- scale <<= 1;
-
- return clamp_val(DIV_ROUND_CLOSEST(val, scale), 0, 127);
-}
-
static u16 nct6683_read(struct nct6683_data *data, u16 reg)
{
int res;
--
1.8.3.1

2021-04-13 21:43:35

by Guenter Roeck

Subject: Re: [PATCH] hwmon: (nct6683) remove useless function

On Tue, Apr 13, 2021 at 02:02:50PM +0800, Jiapeng Chong wrote:
> Fix the following clang warning:
>
> drivers/hwmon/nct6683.c:491:19: warning: unused function 'in_to_reg'
> [-Wunused-function].
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Jiapeng Chong <[email protected]>

Applied.

Thanks,
Guenter

> ---
> drivers/hwmon/nct6683.c | 11 -----------
> 1 file changed, 11 deletions(-)
>
> diff --git a/drivers/hwmon/nct6683.c b/drivers/hwmon/nct6683.c
> index a23047a..b886cf0 100644
> --- a/drivers/hwmon/nct6683.c
> +++ b/drivers/hwmon/nct6683.c
> @@ -488,17 +488,6 @@ static inline long in_from_reg(u16 reg, u8 src)
> return reg * scale;
> }
>
> -static inline u16 in_to_reg(u32 val, u8 src)
> -{
> - int scale = 16;
> -
> - if (src == MON_SRC_VCC || src == MON_SRC_VSB || src == MON_SRC_AVSB ||
> - src == MON_SRC_VBAT)
> - scale <<= 1;
> -
> - return clamp_val(DIV_ROUND_CLOSEST(val, scale), 0, 127);
> -}
> -
> static u16 nct6683_read(struct nct6683_data *data, u16 reg)
> {
> int res;