2021-04-14 10:14:14

by Jiapeng Chong

Subject: [PATCH] memstick: r592: remove unused variable

Fix the following clang warning:

drivers/memstick/host/r592.c:363:6: warning: variable ‘len’ set but not
used [-Wunused-but-set-variable].

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
drivers/memstick/host/r592.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/memstick/host/r592.c b/drivers/memstick/host/r592.c
index d2ef463..026fada 100644
--- a/drivers/memstick/host/r592.c
+++ b/drivers/memstick/host/r592.c
@@ -360,12 +360,11 @@ static void r592_write_fifo_pio(struct r592_device *dev,
static void r592_flush_fifo_write(struct r592_device *dev)
{
u8 buffer[4] = { 0 };
- int len;

if (kfifo_is_empty(&dev->pio_fifo))
return;

- len = kfifo_out(&dev->pio_fifo, buffer, 4);
+ kfifo_out(&dev->pio_fifo, buffer, 4);
r592_write_reg_raw_be(dev, R592_FIFO_PIO, *(u32 *)buffer);
}

--
1.8.3.1

2021-04-15 12:04:00

by Ulf Hansson

Subject: Re: [PATCH] memstick: r592: remove unused variable

On Wed, 14 Apr 2021 at 04:21, Jiapeng Chong
<[email protected]> wrote:
>
> Fix the following clang warning:
>
> drivers/memstick/host/r592.c:363:6: warning: variable ‘len’ set but not
> used [-Wunused-but-set-variable].
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Jiapeng Chong <[email protected]>

Applied for next, thanks!

Kind regards
Uffe


> ---
> drivers/memstick/host/r592.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/memstick/host/r592.c b/drivers/memstick/host/r592.c
> index d2ef463..026fada 100644
> --- a/drivers/memstick/host/r592.c
> +++ b/drivers/memstick/host/r592.c
> @@ -360,12 +360,11 @@ static void r592_write_fifo_pio(struct r592_device *dev,
> static void r592_flush_fifo_write(struct r592_device *dev)
> {
> u8 buffer[4] = { 0 };
> - int len;
>
> if (kfifo_is_empty(&dev->pio_fifo))
> return;
>
> - len = kfifo_out(&dev->pio_fifo, buffer, 4);
> + kfifo_out(&dev->pio_fifo, buffer, 4);
> r592_write_reg_raw_be(dev, R592_FIFO_PIO, *(u32 *)buffer);
> }
>
> --
> 1.8.3.1
>