2021-04-27 04:45:27

by Jiabing Wan

Subject: [PATCH] hwmon: Remove unneeded semicolons

Fix the following coccicheck warning:

./drivers/hwmon/corsair-psu.c:379:2-3: Unneeded semicolon

Remove unneeded semicolons.

Signed-off-by: Wan Jiabing <[email protected]>
---
drivers/hwmon/corsair-psu.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/hwmon/corsair-psu.c b/drivers/hwmon/corsair-psu.c
index 3a5807e4a2ef..02298b86b57b 100644
--- a/drivers/hwmon/corsair-psu.c
+++ b/drivers/hwmon/corsair-psu.c
@@ -355,7 +355,7 @@ static umode_t corsairpsu_hwmon_power_is_visible(const struct corsairpsu_data *p
return 0444;
default:
return 0;
- };
+ }
}

static umode_t corsairpsu_hwmon_in_is_visible(const struct corsairpsu_data *priv, u32 attr,
@@ -376,7 +376,7 @@ static umode_t corsairpsu_hwmon_in_is_visible(const struct corsairpsu_data *priv
break;
default:
break;
- };
+ }

return res;
}
--
2.25.1

2021-04-27 14:52:16

by Guenter Roeck

Subject: Re: [PATCH] hwmon: Remove unneeded semicolons

Hi,

On Tue, Apr 27, 2021 at 12:42:19PM +0800, Wan Jiabing wrote:
> Fix the following coccicheck warning:
>
> ./drivers/hwmon/corsair-psu.c:379:2-3: Unneeded semicolon
>
> Remove unneeded semicolons.
>
> Signed-off-by: Wan Jiabing <[email protected]>

Thanks a lot for your patch; applied.

In the future, please add the affected driver to the subject line, as in

hwmon: (corsair-psu) ...

Thanks,
Guenter

> ---
> drivers/hwmon/corsair-psu.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/hwmon/corsair-psu.c b/drivers/hwmon/corsair-psu.c
> index 3a5807e4a2ef..02298b86b57b 100644
> --- a/drivers/hwmon/corsair-psu.c
> +++ b/drivers/hwmon/corsair-psu.c
> @@ -355,7 +355,7 @@ static umode_t corsairpsu_hwmon_power_is_visible(const struct corsairpsu_data *p
> return 0444;
> default:
> return 0;
> - };
> + }
> }
>
> static umode_t corsairpsu_hwmon_in_is_visible(const struct corsairpsu_data *priv, u32 attr,
> @@ -376,7 +376,7 @@ static umode_t corsairpsu_hwmon_in_is_visible(const struct corsairpsu_data *priv
> break;
> default:
> break;
> - };
> + }
>
> return res;
> }
> --
> 2.25.1
>