2021-05-06 12:51:33

by Wei Ming Chen

Subject: [PATCH] ACPICA: Use fallthrough pseudo-keyword

Replace /* FALLTHROUGH */ comment with pseudo-keyword macro fallthrough[1]

[1] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through

Signed-off-by: Wei Ming Chen <[email protected]>
---
drivers/acpi/acpica/utprint.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/acpi/acpica/utprint.c b/drivers/acpi/acpica/utprint.c
index e37d612e8db5..0b511434b80b 100644
--- a/drivers/acpi/acpica/utprint.c
+++ b/drivers/acpi/acpica/utprint.c
@@ -475,7 +475,7 @@ int vsnprintf(char *string, acpi_size size, const char *format, va_list args)
case 'X':

type |= ACPI_FORMAT_UPPER;
- /* FALLTHROUGH */
+ fallthrough;

case 'x':

--
2.25.1

2021-05-10 17:08:01

by Rafael J. Wysocki

Subject: Re: [PATCH] ACPICA: Use fallthrough pseudo-keyword

On Thu, May 6, 2021 at 2:49 PM Wei Ming Chen <[email protected]> wrote:
>
> Replace /* FALLTHROUGH */ comment with pseudo-keyword macro fallthrough[1]
>
> [1] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through
>
> Signed-off-by: Wei Ming Chen <[email protected]>
> ---
> drivers/acpi/acpica/utprint.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/acpica/utprint.c b/drivers/acpi/acpica/utprint.c
> index e37d612e8db5..0b511434b80b 100644
> --- a/drivers/acpi/acpica/utprint.c
> +++ b/drivers/acpi/acpica/utprint.c
> @@ -475,7 +475,7 @@ int vsnprintf(char *string, acpi_size size, const char *format, va_list args)
> case 'X':
>
> type |= ACPI_FORMAT_UPPER;
> - /* FALLTHROUGH */
> + fallthrough;
>
> case 'x':
>
> --

This is ACPICA material, so I'm leaving it to Erik and Bob.

Thanks!

2021-05-11 18:24:01

by Kaneda, Erik

Subject: RE: [PATCH] ACPICA: Use fallthrough pseudo-keyword

> -----Original Message-----
> From: Wei Ming Chen <[email protected]>
> Sent: Thursday, May 6, 2021 5:49 AM
> To: [email protected]
> Cc: [email protected]; [email protected]; Wei Ming Chen
> <[email protected]>
> Subject: [PATCH] ACPICA: Use fallthrough pseudo-keyword
>
> Replace /* FALLTHROUGH */ comment with pseudo-keyword macro
> fallthrough[1]
>
> [1]
> https://www.kernel.org/doc/html/latest/process/deprecated.html?highligh
> t=fallthrough#implicit-switch-case-fall-through
>
> Signed-off-by: Wei Ming Chen <[email protected]>
> ---
> drivers/acpi/acpica/utprint.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/acpica/utprint.c b/drivers/acpi/acpica/utprint.c
> index e37d612e8db5..0b511434b80b 100644
> --- a/drivers/acpi/acpica/utprint.c
> +++ b/drivers/acpi/acpica/utprint.c
> @@ -475,7 +475,7 @@ int vsnprintf(char *string, acpi_size size, const char
> *format, va_list args)
> case 'X':
>
Hi,

> type |= ACPI_FORMAT_UPPER;
> - /* FALLTHROUGH */
> + fallthrough;

Since fallthrough is specific to gcc, we use the macro ACPI_FALLTHROUGH for code in drivers/acpi/acpica. Please resubmit using this keyword and I can take the commit for upstream ACPICA.

Thanks,
Erik
>
> case 'x':
>
> --
> 2.25.1