2021-05-11 11:35:12

by Yang Yingliang

Subject: [PATCH -next] aoe: remove unnecessary mutex_init()

The mutex ktio_spawn_lock is initialized statically.
It is unnecessary to initialize by mutex_init().

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Yang Yingliang <[email protected]>
---
drivers/block/aoe/aoecmd.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/block/aoe/aoecmd.c b/drivers/block/aoe/aoecmd.c
index ecd77897a761..588889bea7c3 100644
--- a/drivers/block/aoe/aoecmd.c
+++ b/drivers/block/aoe/aoecmd.c
@@ -1701,8 +1701,6 @@ aoecmd_init(void)
goto ktiowq_fail;
}

- mutex_init(&ktio_spawn_lock);
-
for (i = 0; i < ncpus; i++) {
INIT_LIST_HEAD(&iocq[i].head);
spin_lock_init(&iocq[i].lock);
--
2.25.1

2021-05-11 14:17:53

by Jens Axboe

Subject: Re: [PATCH -next] aoe: remove unnecessary mutex_init()

On 5/11/21 5:34 AM, Yang Yingliang wrote:
> The mutex ktio_spawn_lock is initialized statically.
> It is unnecessary to initialize by mutex_init().

Applied, thanks.

--
Jens Axboe