fill_tgid() should skip not only an already exited group leader. If the
task has ->exit_state != 0 it already did exit_notify(), so it also did
fill_tgid_exit()->delayacct_add_tsk(->signal->stats) and we should skip
it to avoid a double accounting.
This patch doesn't close the race completely, but it cleanups the code.
Signed-off-by: Oleg Nesterov <[email protected]>
--- STATS/kernel/taskstats.c~7_estate 2006-10-27 03:03:40.000000000 +0400
+++ STATS/kernel/taskstats.c 2006-10-27 21:34:26.000000000 +0400
@@ -235,7 +235,7 @@ static int fill_tgid(pid_t tgid, struct
tsk = first;
do {
- if (tsk->exit_state == EXIT_ZOMBIE && thread_group_leader(tsk))
+ if (tsk->exit_state)
continue;
/*
* Accounting subsystem can call its functions here to