2021-05-18 21:09:43

by Arnaud Pouliquen

Subject: [PATCH v4 1/4] rpmsg: char: Remove useless include

No facility requests the include of rpmsg_internal.h header file.

Signed-off-by: Arnaud Pouliquen <[email protected]>
---
drivers/rpmsg/rpmsg_char.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/rpmsg/rpmsg_char.c b/drivers/rpmsg/rpmsg_char.c
index 2bebc9b2d163..b5907b80727c 100644
--- a/drivers/rpmsg/rpmsg_char.c
+++ b/drivers/rpmsg/rpmsg_char.c
@@ -22,8 +22,6 @@
#include <linux/uaccess.h>
#include <uapi/linux/rpmsg.h>

-#include "rpmsg_internal.h"
-
#define RPMSG_DEV_MAX (MINORMASK + 1)

static dev_t rpmsg_major;
--
2.17.1

2021-05-25 18:11:54

by Mathieu Poirier

Subject: Re: [PATCH v4 1/4] rpmsg: char: Remove useless include

On Mon, May 17, 2021 at 07:15:28PM +0200, Arnaud Pouliquen wrote:
> No facility requests the include of rpmsg_internal.h header file.
>
> Signed-off-by: Arnaud Pouliquen <[email protected]>
> ---
> drivers/rpmsg/rpmsg_char.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/rpmsg/rpmsg_char.c b/drivers/rpmsg/rpmsg_char.c
> index 2bebc9b2d163..b5907b80727c 100644
> --- a/drivers/rpmsg/rpmsg_char.c
> +++ b/drivers/rpmsg/rpmsg_char.c
> @@ -22,8 +22,6 @@
> #include <linux/uaccess.h>
> #include <uapi/linux/rpmsg.h>
>
> -#include "rpmsg_internal.h"
> -
> #define RPMSG_DEV_MAX (MINORMASK + 1)

Reviewed-by: Mathieu Poirier <[email protected]>

>
> static dev_t rpmsg_major;
> --
> 2.17.1
>