2021-05-24 15:21:26

by Xiongwei Song

Subject: [PATCH] docs: lockdep-design: improve readability of the block matrix

From: Xiongwei Song <[email protected]>

The block condition matrix is using 'E' as the writer notation, however,
the writer reminder below the matrix is using 'W', to make them consistent
and make the matrix more readable, we'd better to use 'W' to represent
writer.

Suggested-by: Waiman Long <[email protected]>
Suggested-by: Boqun Feng <[email protected]>
Signed-off-by: Xiongwei Song <[email protected]>
---
Documentation/locking/lockdep-design.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/locking/lockdep-design.rst b/Documentation/locking/lockdep-design.rst
index 9f3cfca..82f36ca 100644
--- a/Documentation/locking/lockdep-design.rst
+++ b/Documentation/locking/lockdep-design.rst
@@ -453,9 +453,9 @@ There are simply four block conditions:
Block condition matrix, Y means the row blocks the column, and N means otherwise.

+---+---+---+---+
- | | E | r | R |
+ | | W | r | R |
+---+---+---+---+
- | E | Y | Y | Y |
+ | W | Y | Y | Y |
+---+---+---+---+
| r | Y | Y | N |
+---+---+---+---+
--
2.7.4

2021-05-27 06:14:08

by Boqun Feng

Subject: Re: [PATCH] docs: lockdep-design: improve readability of the block matrix

On Mon, May 24, 2021 at 11:05:45PM +0800, Xiongwei Song wrote:
> From: Xiongwei Song <[email protected]>
>
> The block condition matrix is using 'E' as the writer notation, however,
> the writer reminder below the matrix is using 'W', to make them consistent
> and make the matrix more readable, we'd better to use 'W' to represent
> writer.
>
> Suggested-by: Waiman Long <[email protected]>
> Suggested-by: Boqun Feng <[email protected]>
> Signed-off-by: Xiongwei Song <[email protected]>

Reviewed-by: Boqun Feng <[email protected]>

Regards,
Boqun

> ---
> Documentation/locking/lockdep-design.rst | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/locking/lockdep-design.rst b/Documentation/locking/lockdep-design.rst
> index 9f3cfca..82f36ca 100644
> --- a/Documentation/locking/lockdep-design.rst
> +++ b/Documentation/locking/lockdep-design.rst
> @@ -453,9 +453,9 @@ There are simply four block conditions:
> Block condition matrix, Y means the row blocks the column, and N means otherwise.
>
> +---+---+---+---+
> - | | E | r | R |
> + | | W | r | R |
> +---+---+---+---+
> - | E | Y | Y | Y |
> + | W | Y | Y | Y |
> +---+---+---+---+
> | r | Y | Y | N |
> +---+---+---+---+
> --
> 2.7.4
>

2021-05-27 07:35:27

by Peter Zijlstra

Subject: Re: [PATCH] docs: lockdep-design: improve readability of the block matrix

On Thu, May 27, 2021 at 11:30:14AM +0800, Boqun Feng wrote:
> On Mon, May 24, 2021 at 11:05:45PM +0800, Xiongwei Song wrote:
> > From: Xiongwei Song <[email protected]>
> >
> > The block condition matrix is using 'E' as the writer notation, however,
> > the writer reminder below the matrix is using 'W', to make them consistent
> > and make the matrix more readable, we'd better to use 'W' to represent
> > writer.
> >
> > Suggested-by: Waiman Long <[email protected]>
> > Suggested-by: Boqun Feng <[email protected]>
> > Signed-off-by: Xiongwei Song <[email protected]>
>
> Reviewed-by: Boqun Feng <[email protected]>

Thanks!

2021-05-27 13:40:35

by Waiman Long

Subject: Re: [PATCH] docs: lockdep-design: improve readability of the block matrix

On 5/24/21 11:05 AM, Xiongwei Song wrote:
> From: Xiongwei Song <[email protected]>
>
> The block condition matrix is using 'E' as the writer notation, however,
> the writer reminder below the matrix is using 'W', to make them consistent
> and make the matrix more readable, we'd better to use 'W' to represent
> writer.
>
> Suggested-by: Waiman Long <[email protected]>
> Suggested-by: Boqun Feng <[email protected]>
> Signed-off-by: Xiongwei Song <[email protected]>
> ---
> Documentation/locking/lockdep-design.rst | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/locking/lockdep-design.rst b/Documentation/locking/lockdep-design.rst
> index 9f3cfca..82f36ca 100644
> --- a/Documentation/locking/lockdep-design.rst
> +++ b/Documentation/locking/lockdep-design.rst
> @@ -453,9 +453,9 @@ There are simply four block conditions:
> Block condition matrix, Y means the row blocks the column, and N means otherwise.
>
> +---+---+---+---+
> - | | E | r | R |
> + | | W | r | R |
> +---+---+---+---+
> - | E | Y | Y | Y |
> + | W | Y | Y | Y |
> +---+---+---+---+
> | r | Y | Y | N |
> +---+---+---+---+

Acked-by: Waiman Long <[email protected]>

2021-05-31 10:42:14

by tip-bot2 for Alexey Makhalov

Subject: [tip: locking/core] locking/lockdep,doc: Improve readability of the block matrix

The following commit has been merged into the locking/core branch of tip:

Commit-ID: fab6216fafdd74cd84de929ffe7b787976d32cff
Gitweb: https://git.kernel.org/tip/fab6216fafdd74cd84de929ffe7b787976d32cff
Author: Xiongwei Song <[email protected]>
AuthorDate: Mon, 24 May 2021 23:05:45 +08:00
Committer: Peter Zijlstra <[email protected]>
CommitterDate: Mon, 31 May 2021 10:14:54 +02:00

locking/lockdep,doc: Improve readability of the block matrix

The block condition matrix is using 'E' as the writer notation,
however, the writer reminder below the matrix is using 'W', to make
them consistent and make the matrix more readable, we'd better to use
'W' to represent writer.

Suggested-by: Waiman Long <[email protected]>
Suggested-by: Boqun Feng <[email protected]>
Signed-off-by: Xiongwei Song <[email protected]>
Signed-off-by: Peter Zijlstra (Intel) <[email protected]>
Reviewed-by: Boqun Feng <[email protected]>
Link: https://lkml.kernel.org/r/[email protected]
---
Documentation/locking/lockdep-design.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/locking/lockdep-design.rst b/Documentation/locking/lockdep-design.rst
index 9f3cfca..82f36ca 100644
--- a/Documentation/locking/lockdep-design.rst
+++ b/Documentation/locking/lockdep-design.rst
@@ -453,9 +453,9 @@ There are simply four block conditions:
Block condition matrix, Y means the row blocks the column, and N means otherwise.

+---+---+---+---+
- | | E | r | R |
+ | | W | r | R |
+---+---+---+---+
- | E | Y | Y | Y |
+ | W | Y | Y | Y |
+---+---+---+---+
| r | Y | Y | N |
+---+---+---+---+