2021-05-25 11:06:30

by Yang Li

Subject: [PATCH] net: hns: Fix kernel-doc

Fix function name in hns_ethtool.c kernel-doc comment
to remove these warnings found by clang_w1.

drivers/net/ethernet/hisilicon/hns/hns_ethtool.c:202: warning: expecting
prototype for hns_nic_set_link_settings(). Prototype was for
hns_nic_set_link_ksettings() instead.
drivers/net/ethernet/hisilicon/hns/hns_ethtool.c:837: warning: expecting
prototype for get_ethtool_stats(). Prototype was for
hns_get_ethtool_stats() instead.
drivers/net/ethernet/hisilicon/hns/hns_ethtool.c:894: warning:
expecting prototype for get_strings(). Prototype was for
hns_get_strings() instead.

Reported-by: Abaci Robot <[email protected]>
Fixes: 'commit 262b38cdb3e4 ("net: ethernet: hisilicon: hns: use phydev
from struct net_device")'
Signed-off-by: Yang Li <[email protected]>
---
drivers/net/ethernet/hisilicon/hns/hns_ethtool.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/hisilicon/hns/hns_ethtool.c b/drivers/net/ethernet/hisilicon/hns/hns_ethtool.c
index da48c05..7e62dcf 100644
--- a/drivers/net/ethernet/hisilicon/hns/hns_ethtool.c
+++ b/drivers/net/ethernet/hisilicon/hns/hns_ethtool.c
@@ -192,7 +192,7 @@ static int hns_nic_get_link_ksettings(struct net_device *net_dev,
}

/**
- *hns_nic_set_link_settings - implement ethtool set link ksettings
+ *hns_nic_set_link_ksettings - implement ethtool set link ksettings
*@net_dev: net_device
*@cmd: ethtool_link_ksettings
*retuen 0 - success , negative --fail
@@ -827,7 +827,7 @@ static int hns_set_coalesce(struct net_device *net_dev,
}

/**
- * get_ethtool_stats - get detail statistics.
+ * hns_get_ethtool_stats - get detail statistics.
* @netdev: net device
* @stats: statistics info.
* @data: statistics data.
@@ -885,7 +885,7 @@ static void hns_get_ethtool_stats(struct net_device *netdev,
}

/**
- * get_strings: Return a set of strings that describe the requested objects
+ * hns_get_strings: Return a set of strings that describe the requested objects
* @netdev: net device
* @stringset: string set ID.
* @data: objects data.
--
1.8.3.1

2021-05-26 01:04:24

by patchwork-bot+netdevbpf

Subject: Re: [PATCH] net: hns: Fix kernel-doc

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Tue, 25 May 2021 18:52:47 +0800 you wrote:
> Fix function name in hns_ethtool.c kernel-doc comment
> to remove these warnings found by clang_w1.
>
> drivers/net/ethernet/hisilicon/hns/hns_ethtool.c:202: warning: expecting
> prototype for hns_nic_set_link_settings(). Prototype was for
> hns_nic_set_link_ksettings() instead.
> drivers/net/ethernet/hisilicon/hns/hns_ethtool.c:837: warning: expecting
> prototype for get_ethtool_stats(). Prototype was for
> hns_get_ethtool_stats() instead.
> drivers/net/ethernet/hisilicon/hns/hns_ethtool.c:894: warning:
> expecting prototype for get_strings(). Prototype was for
> hns_get_strings() instead.
>
> [...]

Here is the summary with links:
- net: hns: Fix kernel-doc
https://git.kernel.org/netdev/net/c/c1cf1afd8b0f

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html