2021-06-04 03:04:12

by Jiabing Wan

[permalink] [raw]
Subject: [PATCH] ASoC: Remove unneeded semicolon in rk817_codec.c

Fix following coccicheck warning:
./sound/soc/codecs/rk817_codec.c:49:2-3: Unneeded semicolon

Signed-off-by: Wan Jiabing <[email protected]>
---
sound/soc/codecs/rk817_codec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/codecs/rk817_codec.c b/sound/soc/codecs/rk817_codec.c
index fd3a5ba034a9..414d21f22a05 100644
--- a/sound/soc/codecs/rk817_codec.c
+++ b/sound/soc/codecs/rk817_codec.c
@@ -46,7 +46,7 @@ static int rk817_init(struct snd_soc_component *component)
if (rk817->mic_in_differential) {
snd_soc_component_update_bits(component, RK817_CODEC_AMIC_CFG0, MIC_DIFF_MASK,
MIC_DIFF_EN);
- };
+ }
return 0;
}

--
2.20.1


2021-06-04 14:28:45

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH] ASoC: Remove unneeded semicolon in rk817_codec.c

On Fri, Jun 04, 2021 at 11:00:23AM +0800, Wan Jiabing wrote:
> Fix following coccicheck warning:
> ./sound/soc/codecs/rk817_codec.c:49:2-3: Unneeded semicolon

This doesn't apply against current code, please check and resend.


Attachments:
(No filename) (231.00 B)
signature.asc (499.00 B)
Download all attachments

2021-06-05 01:00:05

by Jiabing Wan

[permalink] [raw]
Subject: Re:Re: [PATCH] ASoC: Remove unneeded semicolon in rk817_codec.c


Hi, Mark

>On Fri, Jun 04, 2021 at 11:00:23AM +0800, Wan Jiabing wrote:
>> Fix following coccicheck warning:
>> ./sound/soc/codecs/rk817_codec.c:49:2-3: Unneeded semicolon
>
>This doesn't apply against current code, please check and resend.

I fixed this based on next-20210603.
And this also applies against next-20210604.

It might be my fault that I didn't decribe the version clearly.

Should I write some description at subject line when working on ASoC of linux-next?

Thanks,
Jiabing

2021-06-07 12:38:12

by Mark Brown

[permalink] [raw]
Subject: Re: Re: [PATCH] ASoC: Remove unneeded semicolon in rk817_codec.c

On Sat, Jun 05, 2021 at 08:58:31AM +0800, Jiabing Wan wrote:
> >On Fri, Jun 04, 2021 at 11:00:23AM +0800, Wan Jiabing wrote:
> >> Fix following coccicheck warning:
> >> ./sound/soc/codecs/rk817_codec.c:49:2-3: Unneeded semicolon
> >
> >This doesn't apply against current code, please check and resend.

> I fixed this based on next-20210603.
> And this also applies against next-20210604.

> It might be my fault that I didn't decribe the version clearly.

> Should I write some description at subject line when working on ASoC of linux-next?

I tried to apply this against my current -next targetted code, it's
possible some change happened since the last time -next was built.


Attachments:
(No filename) (696.00 B)
signature.asc (499.00 B)
Download all attachments