Changes in v3
- edit comment and the subject
Changes in v2
- use %s replace function name for the panic() call
- use %s replace function name:kmem_cache_destroy
gumingtao (1):
slab: Use __func__ to trace function name
mm/slab_common.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
--
2.7.4
It is better to use __func__ to trace function name.
Signed-off-by: gumingtao <[email protected]>
---
mm/slab_common.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/mm/slab_common.c b/mm/slab_common.c
index a4a5714..ffa3b11 100644
--- a/mm/slab_common.c
+++ b/mm/slab_common.c
@@ -378,11 +378,11 @@ kmem_cache_create_usercopy(const char *name,
if (err) {
if (flags & SLAB_PANIC)
- panic("kmem_cache_create: Failed to create slab '%s'. Error %d\n",
- name, err);
+ panic("%s: Failed to create slab '%s'. Error %d\n",
+ __func__, name, err);
else {
- pr_warn("kmem_cache_create(%s) failed with error %d\n",
- name, err);
+ pr_warn("%s(%s) failed with error %d\n",
+ __func__, name, err);
dump_stack();
}
return NULL;
@@ -509,8 +509,8 @@ void kmem_cache_destroy(struct kmem_cache *s)
err = shutdown_cache(s);
if (err) {
- pr_err("kmem_cache_destroy %s: Slab cache still has objects\n",
- s->name);
+ pr_err("%s %s: Slab cache still has objects\n",
+ __func__, s->name);
dump_stack();
}
out_unlock:
--
2.7.4
On Tue, 22 Jun 2021, gumingtao wrote:
> It is better to use __func__ to trace function name.
Acked-by: Christoph Lameter <[email protected]>
On Tue, 22 Jun 2021, gumingtao wrote:
> It is better to use __func__ to trace function name.
>
> Signed-off-by: gumingtao <[email protected]>
Acked-by: David Rientjes <[email protected]>
On Tue 2021-06-22 17:59 +0800, gumingtao wrote:
> It is better to use __func__ to trace function name.
>
> Signed-off-by: gumingtao <[email protected]>
> ---
> mm/slab_common.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
Reviewed-by: Aaron Tomlin <[email protected]>
--
Aaron Tomlin