2021-08-19 08:25:33

by Jiapeng Chong

[permalink] [raw]
Subject: [PATCH] fs/ntfs3: Remove unused including <linux/version.h>

Eliminate the follow versioncheck warning:

./fs/ntfs3/inode.c: 16 linux/version.h not needed.

Reported-by: Abaci Robot <[email protected]>
Fixes: 82cae269cfa9 ("fs/ntfs3: Add initialization of super block")
Signed-off-by: Jiapeng Chong <[email protected]>
---
fs/ntfs3/inode.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/fs/ntfs3/inode.c b/fs/ntfs3/inode.c
index bf51e29..bb01f1b 100644
--- a/fs/ntfs3/inode.c
+++ b/fs/ntfs3/inode.c
@@ -13,7 +13,6 @@
#include <linux/namei.h>
#include <linux/nls.h>
#include <linux/uio.h>
-#include <linux/version.h>
#include <linux/writeback.h>

#include "debug.h"
--
1.8.3.1


2021-08-19 11:06:23

by Kari Argillander

[permalink] [raw]
Subject: Re: [PATCH] fs/ntfs3: Remove unused including <linux/version.h>

On Thu, Aug 19, 2021 at 04:23:37PM +0800, Jiapeng Chong wrote:
> Eliminate the follow versioncheck warning:
>
> ./fs/ntfs3/inode.c: 16 linux/version.h not needed.
>
> Reported-by: Abaci Robot <[email protected]>
> Fixes: 82cae269cfa9 ("fs/ntfs3: Add initialization of super block")
> Signed-off-by: Jiapeng Chong <[email protected]>

Reviewed-by: Kari Argillander <[email protected]>

> ---
> fs/ntfs3/inode.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/ntfs3/inode.c b/fs/ntfs3/inode.c
> index bf51e29..bb01f1b 100644
> --- a/fs/ntfs3/inode.c
> +++ b/fs/ntfs3/inode.c
> @@ -13,7 +13,6 @@
> #include <linux/namei.h>
> #include <linux/nls.h>
> #include <linux/uio.h>
> -#include <linux/version.h>
> #include <linux/writeback.h>
>
> #include "debug.h"
> --
> 1.8.3.1
>

2021-08-27 16:33:53

by Konstantin Komarov

[permalink] [raw]
Subject: RE: [PATCH] fs/ntfs3: Remove unused including <linux/version.h>

> From: Jiapeng Chong <[email protected]>
> Sent: Thursday, August 19, 2021 11:24 AM
> To: Konstantin Komarov <[email protected]>
> Cc: [email protected]; [email protected]; [email protected]; [email protected]; clang-built-
> [email protected]; Jiapeng Chong <[email protected]>
> Subject: [PATCH] fs/ntfs3: Remove unused including <linux/version.h>
>
> Eliminate the follow versioncheck warning:
>
> ./fs/ntfs3/inode.c: 16 linux/version.h not needed.
>
> Reported-by: Abaci Robot <[email protected]>
> Fixes: 82cae269cfa9 ("fs/ntfs3: Add initialization of super block")
> Signed-off-by: Jiapeng Chong <[email protected]>
> ---
> fs/ntfs3/inode.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/ntfs3/inode.c b/fs/ntfs3/inode.c
> index bf51e29..bb01f1b 100644
> --- a/fs/ntfs3/inode.c
> +++ b/fs/ntfs3/inode.c
> @@ -13,7 +13,6 @@
> #include <linux/namei.h>
> #include <linux/nls.h>
> #include <linux/uio.h>
> -#include <linux/version.h>
> #include <linux/writeback.h>
>
> #include "debug.h"
> --
> 1.8.3.1
Hi Jiapeng! Applied, thanks.
Best regards.