2021-08-22 22:55:36

by Joe Lawrence

Subject: [PATCH v3 0/2] objtool: altinstructions fix and cleanup

This version won't eat your memory and swap when building the entire
kernel. Apologies to Andy who discovered this over the weekend.

Tested full build and boot w/o problem. The vmlinux sections, relocs,
size, etc. all appear to be the same before and after this set.
External tooling (kpatch-build) is happy, too.

v3:
- fix bug introduced in arch_decode_instruction() [andy]

v2:
- drop the sec->len update from the first patch [josh]
- rip out sec->len as suggested [josh]


Joe Lawrence (2):
objtool: make .altinstructions section entry size consistent
objtool: remove redundant len value from struct section

tools/objtool/arch/x86/decode.c | 2 +-
tools/objtool/check.c | 16 ++++++++--------
tools/objtool/elf.c | 14 ++++++--------
tools/objtool/include/objtool/elf.h | 1 -
tools/objtool/orc_gen.c | 2 +-
tools/objtool/special.c | 4 ++--
6 files changed, 18 insertions(+), 21 deletions(-)

--
2.26.3

2021-09-03 11:19:35

by Miroslav Benes

Subject: Re: [PATCH v3 0/2] objtool: altinstructions fix and cleanup

On Sun, 22 Aug 2021, Joe Lawrence wrote:

> This version won't eat your memory and swap when building the entire
> kernel. Apologies to Andy who discovered this over the weekend.
>
> Tested full build and boot w/o problem. The vmlinux sections, relocs,
> size, etc. all appear to be the same before and after this set.
> External tooling (kpatch-build) is happy, too.
>
> v3:
> - fix bug introduced in arch_decode_instruction() [andy]
>
> v2:
> - drop the sec->len update from the first patch [josh]
> - rip out sec->len as suggested [josh]
>
>
> Joe Lawrence (2):
> objtool: make .altinstructions section entry size consistent
> objtool: remove redundant len value from struct section

Reviewed-by: Miroslav Benes <[email protected]>

M

2021-09-04 05:23:43

by Josh Poimboeuf

Subject: Re: [PATCH v3 0/2] objtool: altinstructions fix and cleanup

On Sun, Aug 22, 2021 at 06:50:35PM -0400, Joe Lawrence wrote:
> This version won't eat your memory and swap when building the entire
> kernel. Apologies to Andy who discovered this over the weekend.
>
> Tested full build and boot w/o problem. The vmlinux sections, relocs,
> size, etc. all appear to be the same before and after this set.
> External tooling (kpatch-build) is happy, too.
>
> v3:
> - fix bug introduced in arch_decode_instruction() [andy]
>
> v2:
> - drop the sec->len update from the first patch [josh]
> - rip out sec->len as suggested [josh]
>
>
> Joe Lawrence (2):
> objtool: make .altinstructions section entry size consistent
> objtool: remove redundant len value from struct section

Thanks! Queueing up for testing.

--
Josh