2021-09-11 14:30:07

by Peter Zijlstra

Subject: [PATCH] Makefile: 'Promote' -Wunused-but-set-variable to W=3

Upgrade -Wunused-but-set-variable to W=3 to avoid the build robots
sending endless spam for this garbage warning.

By promoting it to W=3 the robots will no longer report it and people
will no longer attempt to fix them by making the code worse.

Signed-off-by: Peter Zijlstra (Intel) <[email protected]>
---
diff --git a/scripts/Makefile.extrawarn b/scripts/Makefile.extrawarn
index d53825503874..6686cc587d3b 100644
--- a/scripts/Makefile.extrawarn
+++ b/scripts/Makefile.extrawarn
@@ -28,7 +28,6 @@ KBUILD_CFLAGS += -Wmissing-format-attribute
KBUILD_CFLAGS += -Wmissing-prototypes
KBUILD_CFLAGS += -Wold-style-definition
KBUILD_CFLAGS += -Wmissing-include-dirs
-KBUILD_CFLAGS += $(call cc-option, -Wunused-but-set-variable)
KBUILD_CFLAGS += $(call cc-option, -Wunused-const-variable)
KBUILD_CFLAGS += $(call cc-option, -Wpacked-not-aligned)
KBUILD_CFLAGS += $(call cc-option, -Wstringop-truncation)
@@ -88,6 +87,7 @@ KBUILD_CFLAGS += -Wredundant-decls
KBUILD_CFLAGS += -Wsign-compare
KBUILD_CFLAGS += -Wswitch-default
KBUILD_CFLAGS += $(call cc-option, -Wpacked-bitfield-compat)
+KBUILD_CFLAGS += $(call cc-option, -Wunused-but-set-variable)

KBUILD_CPPFLAGS += -DKBUILD_EXTRA_WARN3

2021-09-11 21:44:08

by Segher Boessenkool

Subject: Re: [PATCH] Makefile: 'Promote' -Wunused-but-set-variable to W=3

On Sat, Sep 11, 2021 at 04:29:05PM +0200, Peter Zijlstra wrote:
> Upgrade -Wunused-but-set-variable to W=3 to avoid the build robots
> sending endless spam for this garbage warning.

"This warning for garbage code" you mean?

> By promoting it to W=3 the robots will no longer report it and people
> will no longer attempt to fix them by making the code worse.

Instead, they will not see such warnings, and make the code worse.


Segher