2021-09-15 11:05:53

by Ramona Alexandra Nechita

[permalink] [raw]

Subject: [PATCH] power: supply: Specify variations of MAX8903

---

MAX8903 has multiple variations (A-E/G/H/J/N/Y).
Specified them in the Kconfig and in the file comment.

Signed-off-by: Ramona Alexandra Nechita <[email protected]>
---
drivers/power/supply/Kconfig | 2 +-
drivers/power/supply/max8903_charger.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/power/supply/Kconfig b/drivers/power/supply/Kconfig
index c84a7b1caeb6..cca779480b1c 100644
--- a/drivers/power/supply/Kconfig
+++ b/drivers/power/supply/Kconfig
@@ -442,7 +442,7 @@ config CHARGER_ISP1704
ISP1707/ISP1704 USB transceivers.

config CHARGER_MAX8903
- tristate "MAX8903 Battery DC-DC Charger for USB and Adapter Power"
+ tristate "MAX8903A/B/C/D/E/G/H/J/N/Y Battery DC-DC Charger for USB and Adapter Power"
help
Say Y to enable support for the MAX8903 DC-DC charger and sysfs.
The driver supports controlling charger-enable and current-limit
diff --git a/drivers/power/supply/max8903_charger.c b/drivers/power/supply/max8903_charger.c
index 0bd39b0cc257..4e5c669e6607 100644
--- a/drivers/power/supply/max8903_charger.c
+++ b/drivers/power/supply/max8903_charger.c
@@ -1,6 +1,6 @@
// SPDX-License-Identifier: GPL-2.0-or-later
/*
- * max8903_charger.c - Maxim 8903 USB/Adapter Charger Driver
+ * max8903_charger.c - Maxim 8903A/B/C/D/E/G/H/J/N/Y USB/Adapter Charger Driver
*
* Copyright (C) 2011 Samsung Electronics
* MyungJoo Ham <[email protected]>
--
2.25.1

2021-10-13 18:05:03

by Sebastian Reichel

[permalink] [raw]

Subject: Re: [PATCH] power: supply: Specify variations of MAX8903

---

Hi,

On Wed, Sep 15, 2021 at 02:03:40PM +0300, Ramona Alexandra Nechita wrote:
> MAX8903 has multiple variations (A-E/G/H/J/N/Y).
> Specified them in the Kconfig and in the file comment.
>
> Signed-off-by: Ramona Alexandra Nechita <[email protected]>
> ---

why? I would expect people to identify this as the correct driver
without this list and it's definetly not grepable.

-- Sebastian

> drivers/power/supply/Kconfig | 2 +-
> drivers/power/supply/max8903_charger.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/power/supply/Kconfig b/drivers/power/supply/Kconfig
> index c84a7b1caeb6..cca779480b1c 100644
> --- a/drivers/power/supply/Kconfig
> +++ b/drivers/power/supply/Kconfig
> @@ -442,7 +442,7 @@ config CHARGER_ISP1704
> ISP1707/ISP1704 USB transceivers.
>
> config CHARGER_MAX8903
> - tristate "MAX8903 Battery DC-DC Charger for USB and Adapter Power"
> + tristate "MAX8903A/B/C/D/E/G/H/J/N/Y Battery DC-DC Charger for USB and Adapter Power"
> help
> Say Y to enable support for the MAX8903 DC-DC charger and sysfs.
> The driver supports controlling charger-enable and current-limit
> diff --git a/drivers/power/supply/max8903_charger.c b/drivers/power/supply/max8903_charger.c
> index 0bd39b0cc257..4e5c669e6607 100644
> --- a/drivers/power/supply/max8903_charger.c
> +++ b/drivers/power/supply/max8903_charger.c
> @@ -1,6 +1,6 @@
> // SPDX-License-Identifier: GPL-2.0-or-later
> /*
> - * max8903_charger.c - Maxim 8903 USB/Adapter Charger Driver
> + * max8903_charger.c - Maxim 8903A/B/C/D/E/G/H/J/N/Y USB/Adapter Charger Driver
> *
> * Copyright (C) 2011 Samsung Electronics
> * MyungJoo Ham <[email protected]>
> --
> 2.25.1
>

---

Attachments:

(No filename) (1.74 kB)
signature.asc (849.00 B)
Download all attachments