2021-09-20 21:32:11

by Sinthu Raja

Subject: [PATCH V3] dt-bindings: hwlock: omap: Remove redundant binding example

From: Sinthu Raja <[email protected]>

The example includes a board-specific compatible property, this is wrong
as the example should be board agnostic and should represent the particular
binding. Also, the file includes two similar examples but with a different
compatible. So, drop the entire second example

Suggested-by: Bjorn Andersson <[email protected]>
Signed-off-by: Sinthu Raja <[email protected]>

---

Changes in V3:
Addressed review comment, that includes adding Suggested By: tag to the
commit message

V2: https://lore.kernel.org/all/[email protected]/
V1: https://lore.kernel.org/all/[email protected]/

.../bindings/hwlock/ti,omap-hwspinlock.yaml | 33 +------------------
1 file changed, 1 insertion(+), 32 deletions(-)

diff --git a/Documentation/devicetree/bindings/hwlock/ti,omap-hwspinlock.yaml b/Documentation/devicetree/bindings/hwlock/ti,omap-hwspinlock.yaml
index ae1b37dbee75..0a955c7b9706 100644
--- a/Documentation/devicetree/bindings/hwlock/ti,omap-hwspinlock.yaml
+++ b/Documentation/devicetree/bindings/hwlock/ti,omap-hwspinlock.yaml
@@ -39,39 +39,8 @@ additionalProperties: false
examples:

- |
- /* OMAP4 SoCs */
- hwspinlock: spinlock@4a0f6000 {
+ spinlock@4a0f6000 {
compatible = "ti,omap4-hwspinlock";
reg = <0x4a0f6000 0x1000>;
#hwlock-cells = <1>;
};
-
- - |
- / {
- /* K3 AM65x SoCs */
- model = "Texas Instruments K3 AM654 SoC";
- compatible = "ti,am654-evm", "ti,am654";
- #address-cells = <2>;
- #size-cells = <2>;
-
- bus@100000 {
- compatible = "simple-bus";
- #address-cells = <2>;
- #size-cells = <2>;
- ranges = <0x00 0x00100000 0x00 0x00100000 0x00 0x00020000>, /* ctrl mmr */
- <0x00 0x30800000 0x00 0x30800000 0x00 0x0bc00000>; /* Main NavSS */
-
- bus@30800000 {
- compatible = "simple-mfd";
- #address-cells = <2>;
- #size-cells = <2>;
- ranges = <0x00 0x30800000 0x00 0x30800000 0x00 0x0bc00000>;
-
- spinlock@30e00000 {
- compatible = "ti,am654-hwspinlock";
- reg = <0x00 0x30e00000 0x00 0x1000>;
- #hwlock-cells = <1>;
- };
- };
- };
- };
--
2.31.1

2021-09-21 02:57:31

by Suman Anna

Subject: Re: [PATCH V3] dt-bindings: hwlock: omap: Remove redundant binding example

On 9/20/21 7:31 AM, Sinthu Raja wrote:
> From: Sinthu Raja <[email protected]>
>
> The example includes a board-specific compatible property, this is wrong
> as the example should be board agnostic and should represent the particular
> binding. Also, the file includes two similar examples but with a different
> compatible. So, drop the entire second example
>
> Suggested-by: Bjorn Andersson <[email protected]>
> Signed-off-by: Sinthu Raja <[email protected]>

Acked-by: Suman Anna <[email protected]>

>
> ---
>
> Changes in V3:
> Addressed review comment, that includes adding Suggested By: tag to the
> commit message
>
> V2: https://lore.kernel.org/all/[email protected]/
> V1: https://lore.kernel.org/all/[email protected]/
>
> .../bindings/hwlock/ti,omap-hwspinlock.yaml | 33 +------------------
> 1 file changed, 1 insertion(+), 32 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/hwlock/ti,omap-hwspinlock.yaml b/Documentation/devicetree/bindings/hwlock/ti,omap-hwspinlock.yaml
> index ae1b37dbee75..0a955c7b9706 100644
> --- a/Documentation/devicetree/bindings/hwlock/ti,omap-hwspinlock.yaml
> +++ b/Documentation/devicetree/bindings/hwlock/ti,omap-hwspinlock.yaml
> @@ -39,39 +39,8 @@ additionalProperties: false
> examples:
>
> - |
> - /* OMAP4 SoCs */
> - hwspinlock: spinlock@4a0f6000 {
> + spinlock@4a0f6000 {
> compatible = "ti,omap4-hwspinlock";
> reg = <0x4a0f6000 0x1000>;
> #hwlock-cells = <1>;
> };
> -
> - - |
> - / {
> - /* K3 AM65x SoCs */
> - model = "Texas Instruments K3 AM654 SoC";
> - compatible = "ti,am654-evm", "ti,am654";
> - #address-cells = <2>;
> - #size-cells = <2>;
> -
> - bus@100000 {
> - compatible = "simple-bus";
> - #address-cells = <2>;
> - #size-cells = <2>;
> - ranges = <0x00 0x00100000 0x00 0x00100000 0x00 0x00020000>, /* ctrl mmr */
> - <0x00 0x30800000 0x00 0x30800000 0x00 0x0bc00000>; /* Main NavSS */
> -
> - bus@30800000 {
> - compatible = "simple-mfd";
> - #address-cells = <2>;
> - #size-cells = <2>;
> - ranges = <0x00 0x30800000 0x00 0x30800000 0x00 0x0bc00000>;
> -
> - spinlock@30e00000 {
> - compatible = "ti,am654-hwspinlock";
> - reg = <0x00 0x30e00000 0x00 0x1000>;
> - #hwlock-cells = <1>;
> - };
> - };
> - };
> - };
>

2021-09-23 13:14:40

by Rob Herring (Arm)

Subject: Re: [PATCH V3] dt-bindings: hwlock: omap: Remove redundant binding example

On Mon, 20 Sep 2021 18:01:52 +0530, Sinthu Raja wrote:
> From: Sinthu Raja <[email protected]>
>
> The example includes a board-specific compatible property, this is wrong
> as the example should be board agnostic and should represent the particular
> binding. Also, the file includes two similar examples but with a different
> compatible. So, drop the entire second example
>
> Suggested-by: Bjorn Andersson <[email protected]>
> Signed-off-by: Sinthu Raja <[email protected]>
>
> ---
>
> Changes in V3:
> Addressed review comment, that includes adding Suggested By: tag to the
> commit message
>
> V2: https://lore.kernel.org/all/[email protected]/
> V1: https://lore.kernel.org/all/[email protected]/
>
> .../bindings/hwlock/ti,omap-hwspinlock.yaml | 33 +------------------
> 1 file changed, 1 insertion(+), 32 deletions(-)
>

Reviewed-by: Rob Herring <[email protected]>