2006-12-14 15:54:59

by Pierre Peiffer

Subject: [PATCH 2.6.19-rt14][BUG] kernel/sched.c:4135: error: 'notick' undeclared

Hi,

The kernel (sched.c) does not compile if CONFIG_HZ and CONFIG_SMP are set, and
CONFIG_NO_HZ isn't.

Is this patch correct ?

---

Index: linux-2.6.19-rt14-test/kernel/sched.c
===================================================================
--- linux-2.6.19-rt14-test.orig/kernel/sched.c 2006-12-14 16:27:37.000000000 +0100
+++ linux-2.6.19-rt14-test/kernel/sched.c 2006-12-14 16:42:38.000000000 +0100
@@ -4131,7 +4131,7 @@ switch_tasks:
++*switch_count;

prepare_task_switch(rq, next);
-#if defined(CONFIG_HZ) && defined(CONFIG_SMP)
+#if defined(CONFIG_NO_HZ) && defined(CONFIG_SMP)
if (prev == rq->idle && notick.load_balancer == -1) {
/*
* simple selection for now: Nominate the first cpu in


Thanks,

--
Pierre Peiffer

2006-12-14 20:20:31

by Ingo Molnar

Subject: Re: [PATCH 2.6.19-rt14][BUG] kernel/sched.c:4135: error: 'notick' undeclared

* Pierre Peiffer <[email protected]> wrote:

> Hi,
>
> The kernel (sched.c) does not compile if CONFIG_HZ and CONFIG_SMP are
> set, and CONFIG_NO_HZ isn't.

oops - indeed.

> Is this patch correct ?

yeah. (FYI, i had to hand-apply it because it had whitespace damage, all
tabs where spaces)

Ingo