2021-09-27 21:58:36

by Randy Dunlap

Subject: [PATCH] s390/sclp_vt220: fix unused function warning

When CONFIG_SCLP_VT220_TTY=y and CONFIG_SCLP_VT220_CONSOLE is not set:

../drivers/s390/char/sclp_vt220.c:771:13: warning: '__sclp_vt220_flush_buffer' defined but not used [-Wunused-function]
771 | static void __sclp_vt220_flush_buffer(void)

so move this function inside the #ifdef block where it is used.

Signed-off-by: Randy Dunlap <[email protected]>
Cc: Heiko Carstens <[email protected]>
Cc: Vasily Gorbik <[email protected]>
Cc: Christian Borntraeger <[email protected]>
Cc: [email protected]
---
Sorry, I can't determine what the Fixes: tag for this should be
(missing some git fu).

drivers/s390/char/sclp_vt220.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

--- linux-next-20210927.orig/drivers/s390/char/sclp_vt220.c
+++ linux-next-20210927/drivers/s390/char/sclp_vt220.c
@@ -768,6 +768,8 @@ out_driver:
}
__initcall(sclp_vt220_tty_init);

+#ifdef CONFIG_SCLP_VT220_CONSOLE
+
static void __sclp_vt220_flush_buffer(void)
{
unsigned long flags;
@@ -784,8 +786,6 @@ static void __sclp_vt220_flush_buffer(vo
spin_unlock_irqrestore(&sclp_vt220_lock, flags);
}

-#ifdef CONFIG_SCLP_VT220_CONSOLE
-
static void
sclp_vt220_con_write(struct console *con, const char *buf, unsigned int count)
{

2021-09-28 08:35:13

by Heiko Carstens

Subject: Re: [PATCH] s390/sclp_vt220: fix unused function warning

On Mon, Sep 27, 2021 at 02:56:47PM -0700, Randy Dunlap wrote:
> When CONFIG_SCLP_VT220_TTY=y and CONFIG_SCLP_VT220_CONSOLE is not set:
>
> ../drivers/s390/char/sclp_vt220.c:771:13: warning: '__sclp_vt220_flush_buffer' defined but not used [-Wunused-function]
> 771 | static void __sclp_vt220_flush_buffer(void)
>
> so move this function inside the #ifdef block where it is used.
>
> Signed-off-by: Randy Dunlap <[email protected]>
> Cc: Heiko Carstens <[email protected]>
> Cc: Vasily Gorbik <[email protected]>
> Cc: Christian Borntraeger <[email protected]>
> Cc: [email protected]
> ---
> Sorry, I can't determine what the Fixes: tag for this should be
> (missing some git fu).

It's not worth spending time to figure this out.

Applied, thanks!