2021-10-01 02:22:51

by Randy Dunlap

Subject: [PATCH] openrisc: time: don't mark comment as kernel-doc

Fix a kernel-doc warning by unmarking the comment as being in
kernel-doc notation.

Fixes this warning:
arch/openrisc/kernel/time.c:137: warning: expecting prototype for Clocksource(). Prototype was for openrisc_timer_read() instead

Fixes: b731fbbd246e ("OpenRISC: Timekeeping")
Signed-off-by: Randy Dunlap <[email protected]>
Reported-by: kernel test robot <[email protected]>
Cc: Jonas Bonn <[email protected]>
Cc: Stefan Kristiansson <[email protected]>
Cc: Stafford Horne <[email protected]>
Cc: [email protected]
---
arch/openrisc/kernel/time.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-next-20210930.orig/arch/openrisc/kernel/time.c
+++ linux-next-20210930/arch/openrisc/kernel/time.c
@@ -127,7 +127,7 @@ irqreturn_t __irq_entry timer_interrupt(
return IRQ_HANDLED;
}

-/**
+/*
* Clocksource: Based on OpenRISC timer/counter
*
* This sets up the OpenRISC Tick Timer as a clock source. The tick timer

2021-10-02 12:51:55

by Stafford Horne

Subject: Re: [PATCH] openrisc: time: don't mark comment as kernel-doc

On Thu, Sep 30, 2021 at 07:11:01PM -0700, Randy Dunlap wrote:
> Fix a kernel-doc warning by unmarking the comment as being in
> kernel-doc notation.
>
> Fixes this warning:
> arch/openrisc/kernel/time.c:137: warning: expecting prototype for Clocksource(). Prototype was for openrisc_timer_read() instead
>
> Fixes: b731fbbd246e ("OpenRISC: Timekeeping")
> Signed-off-by: Randy Dunlap <[email protected]>
> Reported-by: kernel test robot <[email protected]>
> Cc: Jonas Bonn <[email protected]>
> Cc: Stefan Kristiansson <[email protected]>
> Cc: Stafford Horne <[email protected]>
> Cc: [email protected]
> ---
> arch/openrisc/kernel/time.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-next-20210930.orig/arch/openrisc/kernel/time.c
> +++ linux-next-20210930/arch/openrisc/kernel/time.c
> @@ -127,7 +127,7 @@ irqreturn_t __irq_entry timer_interrupt(
> return IRQ_HANDLED;
> }
>
> -/**
> +/*
> * Clocksource: Based on OpenRISC timer/counter
> *
> * This sets up the OpenRISC Tick Timer as a clock source. The tick timer

Hi Randy,

This looks good to me, thank you. I am queuing it.

-Stafford