2007-01-05 03:28:40

by Mike Frysinger

[permalink] [raw]
Subject: [patch] dont export asm/page.h to userspace

On 1/4/07, Christoph Hellwig <[email protected]> wrote:
> It should not be exported to userspace at all. Care to submit a patch?

trivial patch attached
-mike


Attachments:
(No filename) (160.00 B)
(No filename) (827.00 B)
linux-dont-export-asm-page.patch (325.00 B)
Download all attachments

2007-01-05 05:13:23

by Andrew Morton

[permalink] [raw]
Subject: Re: [patch] dont export asm/page.h to userspace

On Thu, 4 Jan 2007 22:28:30 -0500
Mike Frysinger <[email protected]> wrote:

> On 1/4/07, Christoph Hellwig <[email protected]> wrote:
> > It should not be exported to userspace at all. Care to submit a patch?
>
> trivial patch attached
> -mike
>
>
> [application/pgp-signature (828B)]
>
> [linux-dont-export-asm-page.patch text/x-diff (326B)]
> diff --git a/include/asm-generic/Kbuild.asm b/include/asm-generic/Kbuild.asm
> index a37e95f..642d277 100644
> --- a/include/asm-generic/Kbuild.asm
> +++ b/include/asm-generic/Kbuild.asm
> @@ -32,4 +32,3 @@ unifdef-y += user.h
> # These probably shouldn't be exported
> unifdef-y += shmparam.h
> unifdef-y += elf.h
> -unifdef-y += page.h

box:/usr/src/25> make headers_check
CHK include/linux/version.h
CHK include/linux/compile.h
CHK include/linux/utsrelease.h
make[1]: `scripts/unifdef' is up to date.
REMOVE include/asm/page.h
REMOVE include/asm/.check.page.h
CHECK include/asm-generic/siginfo.h
CHECK include/asm-generic/resource.h
CHECK include/asm-generic/statfs.h
CHECK include/asm-generic/signal.h
CHECK include/asm-generic/mman.h
CHECK include/asm-generic/ipc.h
CHECK include/asm-generic/ioctl.h
CHECK include/asm-generic/fcntl.h
CHECK include/asm-generic/errno.h
CHECK include/asm-generic/errno-base.h
CHECK include/asm/vm86.h
CHECK include/asm/user.h
/usr/src/devel/usr/include/asm/user.h requires asm/page.h, which does not exist in exported headers
make[2]: *** [/usr/src/devel/usr/include/asm/.check.user.h] Error 1
make[1]: *** [asm-i386] Error 2
make: *** [headers_check] Error 2