2007-01-06 16:55:53

by Daniel Walker

Subject: Re: + paravirt-vmi-timer-patches.patch added to -mm tree

On Fri, 2006-12-15 at 14:27 -0800, [email protected] wrote:
> +
> +unsigned long long vmi_sched_clock(void)
> +{
> + return read_available_cycles();
> +}
> +


This sched_clock is likely broken if it's returning something other than
nanoseconds. It looks like cycles, but it's also getting piped through
an ops pointer so I'm not sure what's getting returned here.

Daniel

2007-01-06 20:52:29

by Zachary Amsden

Subject: Re: + paravirt-vmi-timer-patches.patch added to -mm tree

Daniel Walker wrote:
> On Fri, 2006-12-15 at 14:27 -0800, [email protected] wrote:
>
>> +
>> +unsigned long long vmi_sched_clock(void)
>> +{
>> + return read_available_cycles();
>> +}
>> +
>>
>
>
> This sched_clock is likely broken if it's returning something other than
> nanoseconds. It looks like cycles, but it's also getting piped through
> an ops pointer so I'm not sure what's getting returned here.
>

Thanks, I'll fix that.

Zach