2021-11-09 21:55:58

by CGEL

Subject: [PATCH] fs: 9p: remove unneeded variable

From: Changcheng Deng <[email protected]>

Fix the following coccicheck review:
./fs/9p/vfs_file.c: 117: 5-8: Unneeded variable

Remove unneeded variable used to store return value.

Reported-by: Zeal Robot <[email protected]>
Signed-off-by: Changcheng Deng <[email protected]>
---
fs/9p/vfs_file.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/fs/9p/vfs_file.c b/fs/9p/vfs_file.c
index aac46c5e5bba..eec8cf646a52 100644
--- a/fs/9p/vfs_file.c
+++ b/fs/9p/vfs_file.c
@@ -116,7 +116,6 @@ int v9fs_file_open(struct inode *inode, struct file *file)

static int v9fs_file_lock(struct file *filp, int cmd, struct file_lock *fl)
{
- int res = 0;
struct inode *inode = file_inode(filp);

p9_debug(P9_DEBUG_VFS, "filp: %p lock: %p\n", filp, fl);
@@ -126,7 +125,7 @@ static int v9fs_file_lock(struct file *filp, int cmd, struct file_lock *fl)
invalidate_mapping_pages(&inode->i_data, 0, -1);
}

- return res;
+ return 0;
}

static int v9fs_file_do_lock(struct file *filp, int cmd, struct file_lock *fl)
--
2.25.1

2021-11-10 00:50:46

by Dominique Martinet

Subject: Re: [PATCH] fs: 9p: remove unneeded variable

[email protected] wrote on Tue, Nov 09, 2021 at 11:43:43AM +0000:
> From: Changcheng Deng <[email protected]>
>
> Fix the following coccicheck review:
> ./fs/9p/vfs_file.c: 117: 5-8: Unneeded variable
>
> Remove unneeded variable used to store return value.
>
> Reported-by: Zeal Robot <[email protected]>
> Signed-off-by: Changcheng Deng <[email protected]>

Sure, why not.
Queueing this patch.

--
Dominique Martinet