2021-11-14 06:09:13

by Jason Wang

Subject: [PATCH] dmaengine: ppc4xx: remove unused variable `rval'

The variable used for returning status in
`ppc440spe_adma_dma2rxor_prep_src' function is never changed
and this function just need to return 0. Thus, the `rval' can
be removed and return 0 from `ppc440spe_adma_dma2rxor_prep_src'.

Signed-off-by: Jason Wang <[email protected]>
---
drivers/dma/ppc4xx/adma.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/dma/ppc4xx/adma.c b/drivers/dma/ppc4xx/adma.c
index e2b5129c5f84..5e46e347e28b 100644
--- a/drivers/dma/ppc4xx/adma.c
+++ b/drivers/dma/ppc4xx/adma.c
@@ -3240,7 +3240,6 @@ static int ppc440spe_adma_dma2rxor_prep_src(
struct ppc440spe_rxor *cursor, int index,
int src_cnt, u32 addr)
{
- int rval = 0;
u32 sign;
struct ppc440spe_adma_desc_slot *desc = hdesc;
int i;
@@ -3348,7 +3347,7 @@ static int ppc440spe_adma_dma2rxor_prep_src(
break;
}

- return rval;
+ return 0;
}

/**
--
2.33.0

2021-11-25 05:20:17

by Vinod Koul

Subject: Re: [PATCH] dmaengine: ppc4xx: remove unused variable `rval'

On 14-11-21, 14:08, Jason Wang wrote:
> The variable used for returning status in
> `ppc440spe_adma_dma2rxor_prep_src' function is never changed
> and this function just need to return 0. Thus, the `rval' can
> be removed and return 0 from `ppc440spe_adma_dma2rxor_prep_src'.

Applied, thanks

--
~Vinod