Commit 32f6e5da83c7 ("selftests/ftrace: Add kprobe profile testcase")
added a new kprobes testcase, but has a description which does not
describe what the test case is doing and is duplicating the desription
of another test case.
Therefore change the test case description, so it is unique and then
allows easily to tell which test case actually passed or failed.
Reported-by: Alexander Egorenkov <[email protected]>
Signed-off-by: Heiko Carstens <[email protected]>
---
tools/testing/selftests/ftrace/test.d/kprobe/profile.tc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/ftrace/test.d/kprobe/profile.tc b/tools/testing/selftests/ftrace/test.d/kprobe/profile.tc
index 98166fa3eb91..34fb89b0c61f 100644
--- a/tools/testing/selftests/ftrace/test.d/kprobe/profile.tc
+++ b/tools/testing/selftests/ftrace/test.d/kprobe/profile.tc
@@ -1,6 +1,6 @@
#!/bin/sh
# SPDX-License-Identifier: GPL-2.0
-# description: Kprobe dynamic event - adding and removing
+# description: Kprobe profile
# requires: kprobe_events
! grep -q 'myevent' kprobe_profile
--
2.32.0
On Tue, 30 Nov 2021 13:25:46 +0100
Heiko Carstens <[email protected]> wrote:
> Commit 32f6e5da83c7 ("selftests/ftrace: Add kprobe profile testcase")
> added a new kprobes testcase, but has a description which does not
> describe what the test case is doing and is duplicating the desription
> of another test case.
> Therefore change the test case description, so it is unique and then
> allows easily to tell which test case actually passed or failed.
Good catch!
This looks good to me.
Acked-by: Masami Hiramatsu <[email protected]>
Thank you,
>
> Reported-by: Alexander Egorenkov <[email protected]>
> Signed-off-by: Heiko Carstens <[email protected]>
> ---
> tools/testing/selftests/ftrace/test.d/kprobe/profile.tc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/ftrace/test.d/kprobe/profile.tc b/tools/testing/selftests/ftrace/test.d/kprobe/profile.tc
> index 98166fa3eb91..34fb89b0c61f 100644
> --- a/tools/testing/selftests/ftrace/test.d/kprobe/profile.tc
> +++ b/tools/testing/selftests/ftrace/test.d/kprobe/profile.tc
> @@ -1,6 +1,6 @@
> #!/bin/sh
> # SPDX-License-Identifier: GPL-2.0
> -# description: Kprobe dynamic event - adding and removing
> +# description: Kprobe profile
> # requires: kprobe_events
>
> ! grep -q 'myevent' kprobe_profile
> --
> 2.32.0
>
--
Masami Hiramatsu <[email protected]>
On Tue, 30 Nov 2021 23:11:30 +0900
Masami Hiramatsu <[email protected]> wrote:
> On Tue, 30 Nov 2021 13:25:46 +0100
> Heiko Carstens <[email protected]> wrote:
>
> > Commit 32f6e5da83c7 ("selftests/ftrace: Add kprobe profile testcase")
> > added a new kprobes testcase, but has a description which does not
> > describe what the test case is doing and is duplicating the desription
> > of another test case.
> > Therefore change the test case description, so it is unique and then
> > allows easily to tell which test case actually passed or failed.
>
> Good catch!
>
> This looks good to me.
>
> Acked-by: Masami Hiramatsu <[email protected]>
>
Shuah,
Care to take this through your tree?
Thanks!
-- Steve
On 11/30/21 9:01 AM, Steven Rostedt wrote:
> On Tue, 30 Nov 2021 23:11:30 +0900
> Masami Hiramatsu <[email protected]> wrote:
>
>> On Tue, 30 Nov 2021 13:25:46 +0100
>> Heiko Carstens <[email protected]> wrote:
>>
>>> Commit 32f6e5da83c7 ("selftests/ftrace: Add kprobe profile testcase")
>>> added a new kprobes testcase, but has a description which does not
>>> describe what the test case is doing and is duplicating the desription
Typo - I can fix it when I apply. checkpatch.pl does it for you btw.
>>> of another test case.
>>> Therefore change the test case description, so it is unique and then
>>> allows easily to tell which test case actually passed or failed.
>>
>> Good catch!
>>
>> This looks good to me.
>>
>> Acked-by: Masami Hiramatsu <[email protected]>
>>
>
> Shuah,
>
> Care to take this through your tree?
>
Yes. I can queue this up.
thanks,
-- Shuah
On 11/30/21 9:21 AM, Shuah Khan wrote:
> On 11/30/21 9:01 AM, Steven Rostedt wrote:
>> On Tue, 30 Nov 2021 23:11:30 +0900
>> Masami Hiramatsu <[email protected]> wrote:
>>
>>> On Tue, 30 Nov 2021 13:25:46 +0100
>>> Heiko Carstens <[email protected]> wrote:
>>>
>>>> Commit 32f6e5da83c7 ("selftests/ftrace: Add kprobe profile testcase")
>>>> added a new kprobes testcase, but has a description which does not
>>>> describe what the test case is doing and is duplicating the desription
>
> Typo - I can fix it when I apply. checkpatch.pl does it for you btw.
>
>>>> of another test case.
>>>> Therefore change the test case description, so it is unique and then
>>>> allows easily to tell which test case actually passed or failed.
>>>
>>> Good catch!
>>>
>>> This looks good to me.
>>>
>>> Acked-by: Masami Hiramatsu <[email protected]>
>>>
>>
>> Shuah,
>>
>> Care to take this through your tree?
>>
>
> Yes. I can queue this up.
>
Heiko,
Applied now to linux-kselftest next. Run get_maintainers.pl and include
linux-kselftest on your future patches.
thanks,
-- Shuah