2021-12-06 22:28:04

by Thomas Gleixner

Subject: [patch V2 13/23] PCI/MSI: Cleanup include zoo

Get rid of the pile of unneeded includes which accumulated over time.

Signed-off-by: Thomas Gleixner <[email protected]>
Tested-by: Juergen Gross <[email protected]>
Reviewed-by: Jason Gunthorpe <[email protected]>
---
V2: Address build fail on powerpc - Cedric
---
drivers/pci/msi.c | 16 ++++------------
1 file changed, 4 insertions(+), 12 deletions(-)

--- a/drivers/pci/msi.c
+++ b/drivers/pci/msi.c
@@ -7,22 +7,14 @@
* Copyright (C) 2016 Christoph Hellwig.
*/

+#include <linux/acpi_iort.h>
#include <linux/err.h>
-#include <linux/mm.h>
-#include <linux/irq.h>
-#include <linux/interrupt.h>
#include <linux/export.h>
-#include <linux/ioport.h>
-#include <linux/pci.h>
-#include <linux/proc_fs.h>
-#include <linux/msi.h>
-#include <linux/smp.h>
-#include <linux/errno.h>
-#include <linux/io.h>
-#include <linux/acpi_iort.h>
-#include <linux/slab.h>
+#include <linux/irq.h>
#include <linux/irqdomain.h>
+#include <linux/msi.h>
#include <linux/of_irq.h>
+#include <linux/pci.h>

#include "pci.h"

2021-12-07 20:57:19

by Bjorn Helgaas

Subject: Re: [patch V2 13/23] PCI/MSI: Cleanup include zoo

On Mon, Dec 06, 2021 at 11:27:44PM +0100, Thomas Gleixner wrote:
> Get rid of the pile of unneeded includes which accumulated over time.
>
> Signed-off-by: Thomas Gleixner <[email protected]>
> Tested-by: Juergen Gross <[email protected]>
> Reviewed-by: Jason Gunthorpe <[email protected]>

Acked-by: Bjorn Helgaas <[email protected]>

Nice, thanks!

> ---
> V2: Address build fail on powerpc - Cedric
> ---
> drivers/pci/msi.c | 16 ++++------------
> 1 file changed, 4 insertions(+), 12 deletions(-)
>
> --- a/drivers/pci/msi.c
> +++ b/drivers/pci/msi.c
> @@ -7,22 +7,14 @@
> * Copyright (C) 2016 Christoph Hellwig.
> */
>
> +#include <linux/acpi_iort.h>
> #include <linux/err.h>
> -#include <linux/mm.h>
> -#include <linux/irq.h>
> -#include <linux/interrupt.h>
> #include <linux/export.h>
> -#include <linux/ioport.h>
> -#include <linux/pci.h>
> -#include <linux/proc_fs.h>
> -#include <linux/msi.h>
> -#include <linux/smp.h>
> -#include <linux/errno.h>
> -#include <linux/io.h>
> -#include <linux/acpi_iort.h>
> -#include <linux/slab.h>
> +#include <linux/irq.h>
> #include <linux/irqdomain.h>
> +#include <linux/msi.h>
> #include <linux/of_irq.h>
> +#include <linux/pci.h>
>
> #include "pci.h"
>
>

2021-12-09 16:07:25

by tip-bot2 for Alexey Makhalov

Subject: [tip: irq/msi] PCI/MSI: Cleanup include zoo

The following commit has been merged into the irq/msi branch of tip:

Commit-ID: 29a03ada4a007067d5427a6a1b7ba1dc7566ea2e
Gitweb: https://git.kernel.org/tip/29a03ada4a007067d5427a6a1b7ba1dc7566ea2e
Author: Thomas Gleixner <[email protected]>
AuthorDate: Mon, 06 Dec 2021 23:27:44 +01:00
Committer: Thomas Gleixner <[email protected]>
CommitterDate: Thu, 09 Dec 2021 11:52:21 +01:00

PCI/MSI: Cleanup include zoo

Get rid of the pile of unneeded includes which accumulated over time.

Signed-off-by: Thomas Gleixner <[email protected]>
Tested-by: Juergen Gross <[email protected]>
Reviewed-by: Jason Gunthorpe <[email protected]>
Acked-by: Bjorn Helgaas <[email protected]>
Link: https://lore.kernel.org/r/[email protected]

---
drivers/pci/msi.c | 16 ++++------------
1 file changed, 4 insertions(+), 12 deletions(-)

diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c
index 8260b06..a76fcf4 100644
--- a/drivers/pci/msi.c
+++ b/drivers/pci/msi.c
@@ -7,22 +7,14 @@
* Copyright (C) 2016 Christoph Hellwig.
*/

+#include <linux/acpi_iort.h>
#include <linux/err.h>
-#include <linux/mm.h>
-#include <linux/irq.h>
-#include <linux/interrupt.h>
#include <linux/export.h>
-#include <linux/ioport.h>
-#include <linux/pci.h>
-#include <linux/proc_fs.h>
-#include <linux/msi.h>
-#include <linux/smp.h>
-#include <linux/errno.h>
-#include <linux/io.h>
-#include <linux/acpi_iort.h>
-#include <linux/slab.h>
+#include <linux/irq.h>
#include <linux/irqdomain.h>
+#include <linux/msi.h>
#include <linux/of_irq.h>
+#include <linux/pci.h>

#include "pci.h"