2021-12-09 08:29:01

by Hangyu Hua

Subject: [PATCH net] Phonet: refcount leak in pep_sock_accep

sock_hold(sk) is invoked in pep_sock_accept(), but __sock_put(sk) is not
invoked in subsequent failure branches(pep_accept_conn() != 0).

Signed-off-by: Hangyu Hua <[email protected]>
---
net/phonet/pep.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/net/phonet/pep.c b/net/phonet/pep.c
index a1525916885a..b4f90afb0638 100644
--- a/net/phonet/pep.c
+++ b/net/phonet/pep.c
@@ -868,6 +868,7 @@ static struct sock *pep_sock_accept(struct sock *sk, int flags, int *errp,

err = pep_accept_conn(newsk, skb);
if (err) {
+ __sock_put(sk);
sock_put(newsk);
newsk = NULL;
goto drop;
--
2.25.1

2021-12-11 04:40:15

by patchwork-bot+netdevbpf

Subject: Re: [PATCH net] Phonet: refcount leak in pep_sock_accep

Hello:

This patch was applied to netdev/net.git (master)
by Jakub Kicinski <[email protected]>:

On Thu, 9 Dec 2021 16:28:39 +0800 you wrote:
> sock_hold(sk) is invoked in pep_sock_accept(), but __sock_put(sk) is not
> invoked in subsequent failure branches(pep_accept_conn() != 0).
>
> Signed-off-by: Hangyu Hua <[email protected]>
> ---
> net/phonet/pep.c | 1 +
> 1 file changed, 1 insertion(+)

Here is the summary with links:
- [net] Phonet: refcount leak in pep_sock_accep
https://git.kernel.org/netdev/net/c/bcd0f9335332

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html