2021-12-22 07:12:34

by Jiasheng Jiang

Subject: [PATCH] fjes: Check for error irq

I find that platform_get_irq() will not always succeed.
It will return error irq in case of the failure.
Therefore, it might be better to check it if order to avoid the use of
error irq.

Fixes: 658d439b2292 ("fjes: Introduce FUJITSU Extended Socket Network Device driver")
Signed-off-by: Jiasheng Jiang <[email protected]>
---
drivers/net/fjes/fjes_main.c | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/drivers/net/fjes/fjes_main.c b/drivers/net/fjes/fjes_main.c
index e449d9466122..2a569eea4ee8 100644
--- a/drivers/net/fjes/fjes_main.c
+++ b/drivers/net/fjes/fjes_main.c
@@ -1269,6 +1269,11 @@ static int fjes_probe(struct platform_device *plat_dev)
hw->hw_res.start = res->start;
hw->hw_res.size = resource_size(res);
hw->hw_res.irq = platform_get_irq(plat_dev, 0);
+ if (hw->hw_res.irq < 0) {
+ err = hw->hw_res.irq;
+ goto err_free_control_wq;
+ }
+
err = fjes_hw_init(&adapter->hw);
if (err)
goto err_free_control_wq;
--
2.25.1

2021-12-22 10:30:16

by patchwork-bot+netdevbpf

Subject: Re: [PATCH] fjes: Check for error irq

Hello:

This patch was applied to netdev/net.git (master)
by David S. Miller <[email protected]>:

On Wed, 22 Dec 2021 15:12:07 +0800 you wrote:
> I find that platform_get_irq() will not always succeed.
> It will return error irq in case of the failure.
> Therefore, it might be better to check it if order to avoid the use of
> error irq.
>
> Fixes: 658d439b2292 ("fjes: Introduce FUJITSU Extended Socket Network Device driver")
> Signed-off-by: Jiasheng Jiang <[email protected]>
>
> [...]

Here is the summary with links:
- fjes: Check for error irq
https://git.kernel.org/netdev/net/c/db6d6afe382d

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html