2022-01-04 13:11:01

by Alyssa Ross

Subject: [PATCH] serial: liteuart: fix MODULE_ALIAS

modprobe can't handle spaces in aliases.

Fixes: 1da81e5562fa ("drivers/tty/serial: add LiteUART driver")
Signed-off-by: Alyssa Ross <[email protected]>
---
drivers/tty/serial/liteuart.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/liteuart.c b/drivers/tty/serial/liteuart.c
index 2941659e5274..7f74bf7bdcff 100644
--- a/drivers/tty/serial/liteuart.c
+++ b/drivers/tty/serial/liteuart.c
@@ -436,4 +436,4 @@ module_exit(liteuart_exit);
MODULE_AUTHOR("Antmicro <http://www.antmicro.com>");
MODULE_DESCRIPTION("LiteUART serial driver");
MODULE_LICENSE("GPL v2");
-MODULE_ALIAS("platform: liteuart");
+MODULE_ALIAS("platform:liteuart");

base-commit: c9e6606c7fe92b50a02ce51dda82586ebdf99b48
--
2.33.0

2022-01-17 05:35:47

by Stafford Horne

Subject: Re: [PATCH] serial: liteuart: fix MODULE_ALIAS

On Tue, Jan 04, 2022 at 01:10:28PM +0000, Alyssa Ross wrote:
> modprobe can't handle spaces in aliases.
>
> Fixes: 1da81e5562fa ("drivers/tty/serial: add LiteUART driver")
> Signed-off-by: Alyssa Ross <[email protected]>
> ---
> drivers/tty/serial/liteuart.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/liteuart.c b/drivers/tty/serial/liteuart.c
> index 2941659e5274..7f74bf7bdcff 100644
> --- a/drivers/tty/serial/liteuart.c
> +++ b/drivers/tty/serial/liteuart.c
> @@ -436,4 +436,4 @@ module_exit(liteuart_exit);
> MODULE_AUTHOR("Antmicro <http://www.antmicro.com>");
> MODULE_DESCRIPTION("LiteUART serial driver");
> MODULE_LICENSE("GPL v2");
> -MODULE_ALIAS("platform: liteuart");
> +MODULE_ALIAS("platform:liteuart");

This looks fine to me.

Acked-by: Stafford Horne <[email protected]>

> base-commit: c9e6606c7fe92b50a02ce51dda82586ebdf99b48
> --
> 2.33.0
>